1008492 - Update app killing code for Android

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[William Lachance (:wlach)]

So we're still triggering the "app shouldn't be running" exception on Android with the LG device.

We now auto-kill all processes with the name before a test is started, so we really shouldn't have this problem anymore. But this is out of our control, strictly speaking.

I think we should try to kill the app more zealously before the test is run. And rename the exception description to reflect current realities.

Comment 1

[William Lachance (:wlach)]

After looking at the code, I could see one place where the problem might be occurring -- we're doing the check for the process just before the app killing code is engaged. Logically, we should be doing the check after the app killing code.

Comment 2

[William Lachance (:wlach)]

Attachment: Update app killing code on Android

I think this makes more sense than before. I'm going to try running it in production and see what happens.

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 8420467 [details] [diff] [review]
Update app killing code on Android

Review of attachment 8420467 [details] [diff] [review]:
-----------------------------------------------------------------

::: src/eideticker/eideticker/runtest.py
@@ +150,5 @@
> +        num_tries = 0
> +        while device.processExist(appname):
> +            num_tries+=1
> +            if num_tries > 5:
> +                raise Exception("Couldn't successfully kill process after 5 "

I prefer "Could not kill process "+appname+" after 5 attempts"

Comment 4

[William Lachance (:wlach)]

Good idea, pushed with that change:

https://github.com/mozilla/eideticker/commit/766a117b21d1bd5d0bb638fa9ab5c89c84f436c3

(In reply to Geoff Brown [:gbrown] (PTO May 14 - May 21) from comment #3)
> Comment on attachment 8420467 [details] [diff] [review]
> Update app killing code on Android
> 
> Review of attachment 8420467 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: src/eideticker/eideticker/runtest.py
> @@ +150,5 @@
> > +        num_tries = 0
> > +        while device.processExist(appname):
> > +            num_tries+=1
> > +            if num_tries > 5:
> > +                raise Exception("Couldn't successfully kill process after 5 "
> 
> I prefer "Could not kill process "+appname+" after 5 attempts"