1008635 - webloc links not executed

Status: RESOLVED INVALID

(Core :: General, defect)

Description

[Stefan]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140314220517

Steps to reproduce:

Doubleclick a .webloc file containg a valid URL (on Mac OSX)


Actual results:

FF29 opens with the Start Page.
Behaviour since FF29. FF28 works fine here.


Expected results:

FF should have opened the URL from the webloc file  - as expected.

Comment 1

[:Gijs (he/him)]

Does this work if Firefox is already running? Because I can't reproduce in that case, on OS X 10.9.2 (although it's possible the issue is specific to certain version(s) of OS X and/or webloc...). Can you attach an example webloc file that won't open to the bug?

Comment 2

[Stefan]

Attachment: Example Webloc file

Comment 3

[Stefan]

Gijs, 
I'll re-install version 29 and come back with an answer...

Comment 4

[Stefan]

Yes, only occurs when FF is started with that webloc. 
When FF is already running, clicking the webloc works as expected.

Comment 5

[Boris Zbarsky [:bzbarsky]]

We don't have any special handling for "webloc" files in our code that I can see.  So I expect the difference is in how the OS handles these files...

Comment 6

[Boris Zbarsky [:bzbarsky]]

Stefan, if this is a regression from Firefox 28, are you willing to try to narrow down the regression range using http://mozilla.github.io/mozregression/ ?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Also, I just tried this:

  open -a ~/Desktop/Firefox\ 29.app /tmp/test.webloc --args -profile ~/test_profiles/fx29

and it seems to work fine, fwiw...  But only if I've run Firefox 29 against that profile before.

Comment 8

[Stefan]

(In reply to Boris Zbarsky [:bz] from comment #6)
> Stefan, if this is a regression from Firefox 28, are you willing to try to
> narrow down the regression range using
> http://mozilla.github.io/mozregression/ ?

Yes, I can check. Please give me some hint where to start with -good and -bad.

Comment 9

[:Gijs (he/him)]

(In reply to Stefan from comment #8)
> (In reply to Boris Zbarsky [:bz] from comment #6)
> > Stefan, if this is a regression from Firefox 28, are you willing to try to
> > narrow down the regression range using
> > http://mozilla.github.io/mozregression/ ?
> 
> Yes, I can check. Please give me some hint where to start with -good and
> -bad.

--good 2013-12-01 --bad 2014-04-20 to be on the conservative side. It's a binary search, so it doesn't matter too much in terms of how many iterations you'll need to run.

I'm not entirely sure how you'd test this though, because as Boris noted, it works with "open -a", and mozregression will autostart the browser for you... you can then close it and run it manually, of course, but you'd need a way to do that that reproduces what Finder.app is doing when it invokes the webloc file by doubleclicking (which apparently isn't what open -a does...).

Comment 10

[Boris Zbarsky [:bzbarsky]]

> --good 2013-12-01 --bad 2014-04-20 to be on the conservative side.

Not if the problem first appears in 29, right?  28 branched in 2013-10.

Comment 11

[Stefan]

so, then --good 2013-10-01 --bad 2014-04-20 should do the job?

Comment 12

[:Gijs (he/him)]

(In reply to Stefan from comment #11)
> so, then --good 2013-10-01 --bad 2014-04-20 should do the job?

https://wiki.mozilla.org/RapidRelease/Calendar is hard to read, but it basically means 28 became aurora (branched) on December 10th. So December works. </nitpick>

However, I just checked, and on 30 beta, at least, I can't reproduce this, that is, opening a webloc file by doubleclicking opens the browser and opens the relevant tab... Not sure if we just accidentally (or not) fixed it, or if there's some other difference. 

Stefan, did you try a clean profile against 29 yet ( https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles ) ? Might be worth doublechecking...

Comment 13

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #12)
> (In reply to Stefan from comment #11)
> > so, then --good 2013-10-01 --bad 2014-04-20 should do the job?
> 
> https://wiki.mozilla.org/RapidRelease/Calendar is hard to read, but it
> basically means 28 became aurora (branched) on December 10th. So December
> works. </nitpick>

December 9th. I need sleep.

Comment 14

[Stefan]

(In reply to :Gijs Kruitbosch from comment #12)

> Stefan, did you try a clean profile against 29 yet (
> https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-
> firefox-profiles ) ? Might be worth doublechecking...
Just checked a clean profile. No more symptoms :-p
Is there sth like a profile-diff? 
Still have to rescue my saved passwords ...

Comment 15

[Stefan]

While I was rescuing my old profile, I reviewed my add-ons and located the problem: Greasemonkey.
I'm not able investigate further why.
Thanks for your support - Stefan

Comment 16

[Anthony Lieuallen]

FYI: https://github.com/greasemonkey/greasemonkey/issues/1923

Comment 17

[:Gijs (he/him)]

(In reply to Anthony Lieuallen from comment #16)
> FYI: https://github.com/greasemonkey/greasemonkey/issues/1923

Great, thank you!

I'm going to go ahead and mark this one as invalid, as the actual issue is with greasemonkey. :-)

(In reply to Stefan from comment #15)
> While I was rescuing my old profile, I reviewed my add-ons and located the
> problem: Greasemonkey.
> I'm not able investigate further why.
> Thanks for your support - Stefan

Thanks for following up and letting us know! Sorry I didn't make you test this earlier, it might have saved us some trouble... :-\