1008668 - Make Qt port compile on 5.0.2

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Tom S [:evilpie]]

Attachment: visibility

My distribution ships with Qt 5.0.2, but QWindow::setVisibility was introduced in 5.1. As this seems to be to only thing blocking it, we should ifdef it.

Comment 1

[Oleg Romashin (:romaxa)]

Comment on attachment 8420625 [details] [diff] [review]
visibility

Actually setVisibility(Hidden) is just wrapper around QWindow::hide 
Could you check if widget->hide() works for you under Qt 5.0.2 ?

Also please add this into patch header:
# User Tom Schuster <[e-mail]>
Bug 1008668 - Make Qt port compile on 5.0.2. r=romaxa

Comment 2

[Tom S [:evilpie]]

That compiles, but there is still a 1x1 window created with the title "firefox". When I maximize it, it seems to contain about:home?

Comment 3

[Oleg Romashin (:romaxa)]

I believe that is different issue,make sense to check Resize calls.

Probably I don't see that because I have tiled window manager with fixed window frames.
File another bug for that problem

Comment 4

[Tom S [:evilpie]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2882b91ad758

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2882b91ad758