1008818 - OdinMonkey: Add implicitly inherited "use strict" directive in asm.js functions source

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

x = Object
try {
    (function() {
        "use strict";
        eval("\
            Object.toSource = (function() {\
                \"use asm\";\
                function f() {}\
                return f\
            })\
        ")
    })()
} catch (e) {}
print(uneval(x))

$ ./js-dbg-32-dm-ts-darwin-20ca234fd62b --fuzzing-safe --ion-parallel-compile=off 9088.js
function f() {}

$ ./js-dbg-32-dm-ts-darwin-20ca234fd62b --fuzzing-safe --ion-parallel-compile=off --no-fpu 9088.js
function f() {
"use strict";
}

(Tested this on 32-bit Mac js opt threadsafe deterministic shell off m-c rev 20ca234fd62b)

My configure flags are:

LD=ld CROSS_COMPILE=1 CC="clang -Qunused-arguments -msse2 -mfpmath=sse -arch i386" RANLIB=ranlib CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse -arch i386" AS=$CC AR=ar STRIP="strip -x -S" HOST_CC="clang -Qunused-arguments -msse2 -mfpmath=sse" HOST_CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse" sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=i386-apple-darwin9.2.0 --enable-macos-target=10.5 --enable-optimize --enable-debug --enable-profiling --enable-gczeal --enable-debug-symbols --disable-tests --enable-more-deterministic --with-ccache --enable-threadsafe <other NSPR options>


This seems to go way back to rev 37e29c27e6e8, however, Benjamin, do you mind looking at this?

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Nice! asm.js functions can also inherit the strict context, as this test case shows.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Patch + test

This is basically a copy and paste of the AsmJSModuleToString code for implicit strict functions, with the difference that for asm.js functions, the source also contains the function name. Refactoring will come afterwards, for less cognitive load.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Refactoring

Tidy up the two AsmJS*ToString functions.

Comment 4

[Luke Wagner [:luke]]

Comment on attachment 8421081 [details] [diff] [review]
Patch + test

Thanks!

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 8421082 [details] [diff] [review]
Refactoring

Nice!

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b755482b48c9
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/438e99b1cf5a

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b755482b48c9
https://hg.mozilla.org/mozilla-central/rev/438e99b1cf5a