1008831 - Search plugin for www.pledarigrond.ch does not work anymore

Status: RESOLVED FIXED

(Mozilla Localizations :: rm / Romansh, defect)

Description

[Gion-Andri Cantieni [:gion-andri]]

Since an update of www.pledarigrond.ch the searchplugin does not work anymore.

Comment 1

[Gion-Andri Cantieni [:gion-andri]]

Attachment: Patch

Comment 2

[Gion-Andri Cantieni [:gion-andri]]

(In reply to Gion-Andri Cantieni [:gion-andri] from comment #1)
> Created attachment 8420827 [details] [diff] [review]
> Patch

Can I land this on beta and aurora?

Comment 3

[Francesco Lodolo [:flod]]

Comment on attachment 8420827 [details] [diff] [review]
Patch

Review of attachment 8420827 [details] [diff] [review]:
-----------------------------------------------------------------

Applied diff and tested the resulting searchplugin, works fine.

One nit: don't use tabs, if you want to indent some parameters it's better to use a couple of spaces (or change your editor to replace tabs with 2 spaces).

When landing this change use a commit message referencing bug and review, for example "Bug 1008831: Update broken URL template for www.pledarigrond.ch, r=flod", then add a link here to the changesets.

You can land on both mozilla-aurora and mozilla-beta, but this diff won't apply cleanly on mozilla-beta (I didn't add the resultdomain there, only on aurora).

For the future, it would be great to submit a full Mercurial patch instead of a .diff ;-)
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 4

[Gion-Andri Cantieni [:gion-andri]]

Thank you for the review. 
I landed the changes on mozilla-aurora and mozilla-beta: 
http://hg.mozilla.org/releases/l10n/mozilla-aurora/rm/rev/2ca6a4fb6fcf
http://hg.mozilla.org/releases/l10n/mozilla-beta/rm/rev/1cde639e25f5

Thanks for your advice and help! I will post a patch next time :)