Closed
Bug 1008908
Opened 10 years ago
Closed 10 years ago
Useless assignment to 'remainingISize'
Categories
(Core :: Layout: Block and Inline, defect, P5)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(1 file)
|
1.42 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
The value of this assignment to 'remainingISize' is never used: http://hg.mozilla.org/mozilla-central/annotate/3bb70c0d6845/layout/generic/nsLineLayout.cpp#l2579 There used to be a use of 'remainingISize' after the switch but it was removed here: http://hg.mozilla.org/mozilla-central/diff/aeff4052ef00/layout/generic/nsLineLayout.cpp#l1.2526 (it was called 'remainingWidth' back then)
|
Assignee | |
Comment 2•10 years ago
|
||
(removed a superfluous blank line while I'm here)
Attachment #8421236 -
Flags: review?(smontagu)
|
||
Updated•10 years ago
|
Attachment #8421236 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
Hi, could you provide a Try link. Suggestions for what to run if you haven't yet can be found here: https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices
|
|
||
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5537f0724a22
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/5537f0724a22
Assignee: nobody → matspal
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•