1008922 - safebrowsing-backup folder is being created and deleted when phising related files are copied.

Status: RESOLVED INVALID

(Toolkit :: Safe Browsing, defect)

Description

[Catalin Varga [QA][:VarCat]]

Environment:
FF 30.0b3
Build Id:20140508121358
OS: Win 7 x64, Win 8 x64, Win 8 x32

STR:

1. Open FF using a new profile.
2. With Windows Explorer navigate under safebrowsing folder related to the new profile.
3. Wait until the phising files are downloaded under safebrowsing folder.

Expected:
The phising files are successfully downloaded under safebrowsing folder.

Actual:
After the files are downloaded you end up on Windows Explorer under a deleted safebrowsing-backup folder.
It appears that safebrowsing is renamed as safebrowsing-backup and after that deleted. A new safebrowsing folder is created that contains the downloaded phising files.

The bug is reproducible on the latest nightly and latest aurora:
FF 32 
Build Id:20140511030203

FF 31
Build Id: 20140512004006

Note:
1. The issue reproduces on Nightly 30.0a1 2014-03-08

If a regression window is needed please provide the first release that contains the feature the regression window must be done manually due to the nature of the issue.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Monica, is this something you can take on over the next couple of weeks of Beta? If not, whom?

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

Catalin, this sounds like normal operation to me. Are you saying that the final safebrowsing folder does not contain downloaded phishing and malware databases?

I just tried with a clean profile on mac on Nightly 32 and was unable to reproduce (that is, files ended up where I expected them to).

Comment 3

[Gian-Carlo Pascutto [:gcp]]

>Expected:
>The phising files are successfully downloaded under safebrowsing folder.

Isn't that what happens in the end? Sounds like INVALID to me.

Comment 4

[Catalin Varga [QA][:VarCat]]

(In reply to [:mmc] Monica Chew (please use needinfo) from comment #2)
> Catalin, this sounds like normal operation to me. Are you saying that the
> final safebrowsing folder does not contain downloaded phishing and malware
> databases?
> 
> I just tried with a clean profile on mac on Nightly 32 and was unable to
> reproduce (that is, files ended up where I expected them to).

All phishing and malware related files ended up on the correct folder is just is not the original folder, the original folder gets deleted and recreated after each download. During the safebrowsing testing this error was prompted https://drive.google.com/file/d/0B_8A5fiR42AMaVczeG5Fay1mRTA/edit . My guess was that this error was prompted by windows explorer due to this process.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Yeah, that error is from Windows Explorer, not Firefox. This is working as intended. The original folder gets copied to -backup so it can be restored should the browser crash during the update, and gets deleted once the updated folder is correctly written.