1008951 - Sometimes, the panels don't overflow correctly

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Paul Rouget [:paul]]

The DOM is constructed too late, and the panel size doesn't appear to be calculated correctly.

Comment 1

[Paul Rouget [:paul]]

Attachment: v1

Comment 2

[Paul Rouget [:paul]]

STR:
- no phone connected
- open runtime panel
- plug phone

The panel is all messed up (at least on Linux).

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8421002 [details] [diff] [review]
v1

Review of attachment 8421002 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webide/content/webide.js
@@ +202,5 @@
>          this.connectToRuntime(r);
>        }, true);
>      }
>  
> +    while (simulatorListNode.hasChildNodes()) {

Why does moving this block make a difference?

Comment 4

[Paul Rouget [:paul]]

(In reply to J. Ryan Stinnett [:jryans] from comment #3)
> Why does moving this block make a difference?

Panel magic? Not sure why, but it does make a difference.

Comment 5

[Carsten Book [:Tomcat]]

Hi,
could you provide a Try link. Suggestions for what to run if you haven't
yet can be found here:
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

Comment 6

[Paul Rouget [:paul]]

(In reply to Carsten Book [:Tomcat] from comment #5)
> Hi,
> could you provide a Try link. Suggestions for what to run if you haven't
> yet can be found here:
> https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

This is the exception to the rule :) This code is not compiled yet.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/a6368d429fe8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a6368d429fe8