100897 - Redeclaration of var outlinerView in line 568 of searchDialog.js

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Redeclaration of var outlinerView in line 568.

function HandleDeleteOrMoveMessageCompleted(folder)
{
        var outlinerView =
gSearchView.QueryInterface(Components.interfaces.nsIOutlinerView);
        var outlinerSelection = outlinerView.selection;
        viewSize = outlinerView.rowCount;

        if (gNextMessageViewIndexAfterDelete >= viewSize)
        {
            if (viewSize > 0)
                gNextMessageViewIndexAfterDelete = viewSize - 1;
            else
                gNextMessageViewIndexAfterDelete = -1;
        }

        // if we are about to set the selection with a new element then DON'T clear
        // the selection then add the next message to select. This just generates
        // an extra round of command updating notifications that we are trying to
        // optimize away.
        if (gNextMessageViewIndexAfterDelete != -1) {
            outlinerSelection.select(gNextMessageViewIndexAfterDelete);
            // since gNextMessageViewIndexAfterDelete probably has the same value
            // as the last index we had selected, the outliner isn't generating
a new
            // selectionChanged notification for the outliner view. So we aren't
loading the 
            // next message. to fix this, force the selection changed update.
(right here --->)var outlinerView =
gSearchView.QueryInterface(Components.interfaces.nsIOutlinerView);
            if (outlinerView)
                outlinerView.selectionChanged();

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Attachment: The Fix.

Comment 2

[Navin Gupta]

r=naving

Comment 3

[(not reading, please use [e-mail] instead)]

is gSearchView changed between when we first declare it and the second time?  
if not, we can can just remove the second instance.

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

It seems the only thing that gets assigned anything new is the global
gNextMessageViewIndexAfterDelete.  I'll remove the second declaration entirely
and start testing.

Comment 5

[Navin Gupta]

err, that second redeclaration is not required, the entire line can be 
removed. 

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Fix, part deux.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 50213 [details] [diff] [review]
Fix, part deux.

sr=jst

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Fix checked in.

Comment 9

[Suresh]

Marking Verified using todays trunk debug build.