Closed
Bug 1009016
Opened 11 years ago
Closed 11 years ago
Ouija should only retain 6 months of data
Categories
(Testing :: General, defect)
Testing
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dminor, Assigned: jcmojicar)
References
Details
(Whiteboard: [good first bug][mentor=dminor][lang=python])
Attachments
(1 file, 1 obsolete file)
|
1.63 KB,
patch
|
dminor
:
review+
|
Details | Diff | Splinter Review |
Ouija (http://www.github.com/dminor/ouija, running at http:54.215.155.53/index.html) is a tool for analyzing test failure data.
Currently we are retaining all data we collect, but we only really need 6 months of data. The updatedb script (https://github.com/dminor/ouija/blob/master/src/updatedb.py) is run by a cron job daily to collect fresh data.
The clearResults function currently deletes any data from the same range that we are updating to avoid duplicate results. It could delete old data at the same time.
| Assignee | ||
Comment 1•11 years ago
|
||
This will delete tests data older than 183 days. If more accuracy is needed we could use dateutil.relativedelta to work exactly with 6 months.
If you have any comments please let me know.
Attachment #8428205 -
Flags: review?(dminor)
| Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 8428205 [details] [diff] [review]
added a delete sql statement to delete test data older than 183 days
Review of attachment 8428205 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for looking at this! This looks good, but I would prefer to see the two deletes combined with an 'or' statement so we only have to execute one query instead of two - something like date < TOO_OLD or date > DELTA.
Attachment #8428205 -
Flags: review?(dminor) → feedback+
| Assignee | ||
Comment 3•11 years ago
|
||
I joined the deletes for the delta days and the data older than 183 days into one query as requested.
Please let me know if this works for you or if you think there is something else that needs to be changed.
Attachment #8428205 -
Attachment is obsolete: true
Attachment #8428951 -
Flags: review?(dminor)
| Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 8428951 [details] [diff] [review]
0001-join-the-deletes-of-delta-days-data-and-data-older-t.patch
Looks great, thank you for contributing!
Attachment #8428951 -
Flags: review?(dminor) → review+
| Reporter | ||
Comment 5•11 years ago
|
||
Assignee: nobody → jcmojicar
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•