Closed
Bug 1009099
Opened 10 years ago
Closed 10 years ago
Ween GaiaTestCase off wait_for_* methods
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1074117
People
(Reporter: zcampbell, Unassigned)
References
Details
Attachments
(1 file)
No description provided.
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → zcampbell
Comment 1•10 years ago
|
||
I actually have an old patch for this that I could rebase, update, and provide as a starting point, if you want?
Reporter | ||
Comment 2•10 years ago
|
||
I've actually already done it for all except wait_for_condition and except for GaiaEnduranceTestCase (which I'll avoid disrupting): https://github.com/zacc/gaia/commit/5c24cf20c2242207683579e3fe60f0ce64d48a43 Do you think your part will fit in for the `wait_for_condition` part that I still need to do?
Comment 3•10 years ago
|
||
Ah, my patch removed all the wait_for methods, including those in the app objects. I'll hold onto it and rebase in the future, it's not a priority.
Reporter | ||
Comment 4•10 years ago
|
||
Ok, I didn't see the need to be that aggressive just yet, or at least we can do it in steps.
Reporter | ||
Updated•10 years ago
|
Assignee: zcampbell → nobody
Reporter | ||
Comment 5•10 years ago
|
||
This pull is not intended to resolve this bug in one go, it's just a small step to unweaving it to avoid having a large difficult pull request.
Attachment #8458591 -
Flags: review?(rwood)
Attachment #8458591 -
Flags: review?(florin.strugariu)
Comment 6•10 years ago
|
||
Comment on attachment 8458591 [details] [review] github pr LGTM and all of the modified tests passed for me on Flame
Attachment #8458591 -
Flags: review?(rwood) → review+
Comment 7•10 years ago
|
||
Comment on attachment 8458591 [details] [review] github pr All looks OK
Attachment #8458591 -
Flags: review?(florin.strugariu) → review+
Updated•10 years ago
|
Flags: needinfo?(florin.strugariu)
Comment 8•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/0680a4b5ca9cc8ae692572ae101b4fd1ef4a2b4d
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(florin.strugariu)
Resolution: --- → FIXED
Comment 9•10 years ago
|
||
sorry had to revert this change for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=46927889&tree=B2g-Inbound
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
QA Whiteboard: [fxosqa-auto-backlog+]
Comment 10•10 years ago
|
||
Zac mentioned on irc this is a dupe of bug 1074117.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → DUPLICATE
QA Whiteboard: [fxosqa-auto-backlog+] → [fxosqa-auto-dropped-s1]
You need to log in
before you can comment on or make changes to this bug.
Description
•