1009118 - Add isUnlimited method to SliceBudget

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Andrew McCreight [:mccr8]]

I also am doing a little bit of cleanup around initialization.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Add isUnlimited to SliceBudget.

The assertion is slightly silly, except that in the initial version of
this patch I was checking both counter and deadline, but the counter
gets reset in checkOverBudget, even with an unlimited budget, so things
were going haywire in certain situations.  I can remove it if you'd like.

try run on top of a patch that actually uses this in the CC:
  https://tbpl.mozilla.org/?tree=Try&rev=6aa15826b120

Comment 2

[Andrew McCreight [:mccr8]]

(No huge rush on reviewing this, I'm probably not going to land this for a few days to let the telemetry settle down for a previous CC patch.)

Comment 3

[Jon Coppeard (:jonco)]

Comment on attachment 8421800 [details] [diff] [review]
Add isUnlimited to SliceBudget.

Review of attachment 8421800 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +1945,5 @@
>  }
>  
>  SliceBudget::SliceBudget()
> +  : deadline(unlimitedDeadline),
> +    counter(unlimitedStartCounter)

You could just call reset() in the body of the constructor.

@@ +1970,5 @@
>      bool over = PRMJ_Now() > deadline;
>      if (!over)
>          counter = CounterReset;
> +    MOZ_ASSERT(wasUnlimited == isUnlimited(),
> +               "checkOverBudget should not affect whether the budget is unlimited");

I think this is simple enough that the assertion is unnecessary :)

Comment 4

[Andrew McCreight [:mccr8]]

Thanks, I addressed those comments.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bebd8650a712

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bebd8650a712