Closed Bug 1009129 Opened 10 years ago Closed 9 years ago

Intermittent test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test page expected to fail, but all 25 tests passed

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: RyanVM, Unassigned)

Details

(Keywords: intermittent-failure) 

https://tbpl.mozilla.org/php/getParsedLog.php?id=39497256&tree=Mozilla-Inbound

Android 4.0 Panda mozilla-inbound opt test mochitest-gl on 2014-05-12 10:14:22 PDT for push 337ebea094d1
slave: panda-0183

10:29:12     INFO -  6517 INFO TEST-INFO | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] (WebGL mochitest) Starting test page
10:29:12     INFO -  6518 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: NO_ERROR : Should be no errors from setup.
10:29:12     INFO -  6519 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: INVALID_VALUE : gl.texImage2D with NPOT texture with level > 0 should return INVALID_VALUE
10:29:12     INFO -  6520 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: NO_ERROR : gl.texImage2D with NPOT texture at level 0 should succeed
10:29:12     INFO -  6521 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: INVALID_OPERATION : gl.generateMipmap with NPOT texture should return INVALID_OPERATION
10:29:12     INFO -  6522 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - NPOT texture with TEXTURE_WRAP set to REPEAT should draw with 0,0,0,255
10:29:12     INFO -  6523 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: NO_ERROR : Should be no errors from setup.
10:29:12     INFO -  6524 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - NPOT texture with TEXTURE_MIN_FILTER not NEAREST or LINEAR should draw with 0,0,0,255
10:29:12     INFO -  6525 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: NO_ERROR : Should be no errors from setup.
10:29:12     INFO -  6526 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - NPOT texture with TEXTURE_MIN_FILTER set to LINEAR should draw.
10:29:12     INFO -  6527 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: INVALID_VALUE : copyTexImage2D with NPOT texture with level > 0 should return INVALID_VALUE.
10:29:12     INFO -  6528 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: NO_ERROR : gl.texImage2D and gl.generateMipmap with POT texture at level 0 should succeed
10:29:12     INFO -  6529 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - POT texture with TEXTURE_MIN_FILTER set to LINEAR_MIPMAP_LINEAR should draw.
10:29:12     INFO -  6530 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: NO_ERROR : Should be no errors from setup.
10:29:12     INFO -  6531 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: INVALID_VALUE : gl.texImage2D with NPOT texture with level > 0 should return INVALID_VALUE
10:29:12     INFO -  6532 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: NO_ERROR : gl.texImage2D with NPOT texture at level 0 should succeed
10:29:12     INFO -  6533 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: INVALID_OPERATION : gl.generateMipmap with NPOT texture should return INVALID_OPERATION
10:29:12     INFO -  6534 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - NPOT cubemap with TEXTURE_WRAP set to REPEAT should draw with 0,0,0,255
10:29:12     INFO -  6535 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: NO_ERROR : Should be no errors from setup.
10:29:12     INFO -  6536 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - NPOT cubemap with TEXTURE_MIN_FILTER not NEAREST or LINEAR should draw with 0,0,0,255
10:29:12     INFO -  6537 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: NO_ERROR : Should be no errors from setup.
10:29:12     INFO -  6538 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - NPOT cubemap with TEXTURE_MIN_FILTER set to LINEAR should draw.
10:29:12     INFO -  6539 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: NO_ERROR : gl.texImage2D with POT texture at level 0 should succeed
10:29:12     INFO -  6540 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - POT cubemap with TEXTURE_MIN_FILTER set to LINEAR_MIPMAP_LINEAR but no mips draw with 0,0,0,255
10:29:12     INFO -  6541 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - getError was expected value: NO_ERROR : gl.generateMipmap with POT texture should return succeed
10:29:12     INFO -  6542 INFO TEST-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test passed - POT cubemap with TEXTURE_MIN_FILTER set to LINEAR_MIPMAP_LINEAR should draw.
10:29:12     INFO -  6543 INFO TEST-UNEXPECTED-PASS | /tests/content/canvas/test/webgl-conformance/test_webgl_conformance_test_suite.html | [conformance/textures/texture-npot.html] Test page expected to fail, but all 25 tests passed
Retriggers appear to be pointing at bug 997367 as the culprit. Not sure how, but I can't get it to reproduce with ~300 runs on the push prior.
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=Android%204.0%20Panda%20mozilla-inbound%20opt%20test%20mochitest-gl&fromchange=2f7a4bba1dac&tochange=9c4376b338f0
Blocks: 997367
Flags: needinfo?(pchang)
Based on bug 997367 comment 75, the mochitest WebGL was passed.
And I think my modification should not change the WebGL behavior. 

https://tbpl.mozilla.org/php/getParsedLog.php?id=39457119&tree=Try&full=1
Flags: needinfo?(pchang)
This is an *intermittent* failure. You can't judge whether your patch is at fault based on a single run on your Try push. Look at the link in comment 5 and the number of retriggers performed.
And sure enough, the failures are occurring in the Try push too when I retrigger mochitest-gl.

https://tbpl.mozilla.org/?rev=7a9a94aedf0a&tree=Try&jobname=Android%204.0%20Panda%20try%20opt%20test%20mochitest-gl
Flags: needinfo?(pchang)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #7)
> This is an *intermittent* failure. You can't judge whether your patch is at
> fault based on a single run on your Try push. Look at the link in comment 5
> and the number of retriggers performed.

Ok, I got your point. I will add some logs to debug this issue.
Flags: needinfo?(pchang)
Assignee: nobody → pchang
Try run with my patch
https://tbpl.mozilla.org/?rev=85d743adc8d2&tree=Try
P.S. I added some debug log with my patch but I didn't see the debug log for pass and fail cases.

Try run without my patch
https://tbpl.mozilla.org/?tree=Try&rev=1f77e6c17aa8

I saw the WebGL mochitest fail on both try runs. So the problem may already exist for a while or happen recently.
Ryan, how do you think?
Flags: needinfo?(ryanvm)
Can't argue with it still happening post-backout. Off to the resident webgl experts for their help then :)
Flags: needinfo?(ryanvm)
Flags: needinfo?(jgilbert)
Flags: needinfo?(dglastonbury)
No longer blocks: 997367
:jgilbert might have something to add.
Flags: needinfo?(dglastonbury)
Weird, this should certainly never be intermittent.
Flags: needinfo?(jgilbert)
Assignee: pchang → nobody
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.