1009188 - [STK] No help info required (code 13) terminal response is sent back when we click on Help button from the GET INKEY prompt

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Nivi]

Hi,

According to USAT GCF test spec 102.384 section - 27.22.4.2.7 GET INKEY (Help Information), we are supposed to return a terminal response with code '13' - Help Information required by the user when we click on the Help button.

Current behavior is we don't send any TermianlResponse on clicking the Help button. The inputText Timeout comes into play in a bit and we see a code - '12' (No response from user) being sent.

This is not correct. We need to fix this behavior according to what Section 27.22.4.2.7 Step 5 and 6 says. 

5 USER →
  Terminal
  Press "help" key
6 Terminal →
  UICC
  TERMINAL RESPONSE: GET
   7.1.1
  Help info required.

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Timeout for INKEY is measured here:
  https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/icc_worker.js#L278

if no timeout is not provided by the UICC, a default one is used:

https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/icc.js#L9
https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/icc.js#L41
https://github.com/mozilla-b2g/gaia/blob/v1.4/build/config/common-settings.json#L75

This is the function used to show the input box for STK:

https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/icc.js#L385

How many time passes before launch the TERMINAL_RESPONSE?

Comment 2

[Nivi]

Hi Fernando,

The issue is not about the timeout. The problem is that on clicking Help Button, we should send a TR of code 13.
Right now on clicking help button no TR is sent out.

Please look at TS 102.384 Section - 27.22.4.2.7.4 (Expected Sequence 7.1 (GET INKEY, help information available))


PROACTIVE COMMAND: GET INKEY 7.1.1

This is the STK proactive command PDU -

BER-TLV: D0 15 81 03 01 22 80 82 02 81 82 8D 0A 04 45 6E 74 65 72 20 22 2B 22


Command details -
Command number: 1
Command type: GET INKEY
Command qualifier: digits (0-9, *, # and +) only, help information available [Please not help info is available]

Device identities
Source device: UICC
Destination device: Terminal

Text String
Data coding scheme: unpacked, 8 bit data
Text: "Enter "+""

--------------------------------------------------------------------
Expected Behavior: 

On clicking Help Button, we should get a terminal response like this -

TERMINAL RESPONSE: GET INKEY 7.1.1

BER-TLV: 81 03 01 22 80 82 02 82 81 83 01 13

Command details -
Command number: 1
Command type: GET INKEY
Command qualifier: digits (0-9, *, # and +) only, help information available
Device identities
Source device: Terminal
Destination device: UICC
Result
General Result: Help information required by the user
Coding:

------------------------------------------------------------------------------------
Observed behavior: No terminal response is send when we click on the Help button.

Once again, this has nothing to do with the timeout. Sorry for confusing you about that.
The problem is we need to send a TR with result code of 13 (help information requested by user) when user clicks on Help key.

Let me know if you have further questions and I will be glad to answer those.

Thanks,
Nivi.

Comment 3

[Preeti Raghunath(:Preeti)]

Fernando

Can you please take this issue to be fixed?

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Investigating this.

Do you have some logs available?
Command sent?

Thanks

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Currently the input box is called here:

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_worker.js#L285

if you press help, this callback is called:

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc.js#L521

which sents STK_RESULT_HELP_INFO_REQUIRED response (0x13) as defined here:
http://mxr.mozilla.org/mozilla-central/source/dom/webidl/MozIccManager.webidl#83

I think I only need to add the first parameter to the responseSTKCommand call ... I'll fix this asap

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Patch for master branch

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Patch for 1.4 branch

Comment 8

[Nivi]

Comment on attachment 8422324 [details] [review]
Patch for 1.4 branch

Works now. I see a TR with code 13 when I click on Help.

Comment 9

[Nivi]

Comment on attachment 8422323 [details] [review]
Patch for master branch

Since it works on 1.4, I would safely assume it would work on master.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/5936e35e386a65e98d97392799b411203f3b737a
v1.4:   https://github.com/mozilla-b2g/gaia/commit/ddf9c2997ecd46a0e58d1e115ce38a21485e72e1

Comment 11

[Ryan VanderMeulen [:RyanVM]]

*sigh* I was asked to land these only to realize afterwards that they don't have r+ yet...

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Reverted. Let's not do that again please.

Master: https://github.com/mozilla-b2g/gaia/commit/4c45650b6f8747890eba858c954afa612d6a9284
v1.4:   https://github.com/mozilla-b2g/gaia/commit/2a443b78cf722003f0b3a9545bffb937453d527d

Comment 13

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Nivi from comment #8)
> Comment on attachment 8422324 [details] [review]
> Patch for 1.4 branch
> 
> Works now. I see a TR with code 13 when I click on Help.

Cool !

I'll ask for review just now

Comment 14

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8422324 [details] [review]
Patch for 1.4 branch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 15

[Preeti Raghunath(:Preeti)]

Comment on attachment 8422324 [details] [review]
Patch for 1.4 branch

We don not need a gaia approval here. The bug is already a 1.4 blocker

Comment 16

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Master landed again: https://github.com/mozilla-b2g/gaia/commit/c8af639227d3c7e7b15f51d5e9651d964d92b24f

Comment 17

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Preeti Raghunath(:Preeti) from comment #15)
> Comment on attachment 8422324 [details] [review]
> Patch for 1.4 branch
> 
> We don not need a gaia approval here. The bug is already a 1.4 blocker

Oh, thanks. So landing 1.4 too :)

Comment 18

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed in 1.4: https://github.com/mozilla-b2g/gaia/commit/6edb70344916923b89f4cc3b603774904dea852c

Comment 19

[Brogan Zumwalt [Inactive]]

No STR is present to create test case to address bug.