1009226 - [l10n][fr] And Yet Another Android snippet displaying terribly, missing spaces

Status: RESOLVED FIXED

(Snippets Graveyard :: General, defect)

Description

[Jean-Bernard Marcon]

Attachment: screenshot of corpus delicti - androidWidget.png

* this is NOT same bug as https://bugzilla.mozilla.org/show_bug.cgi?id=1002554 but same kind of typography fail.
(see screenshot)

The widget message says:
-"Vous adorez les modules complémentaires?"
should be 
"Vous adorez les modules complémentaires ?"
(the non-breaking space is compulsory for French here)

- "Découvrez des centainesde modulesdisponibles "
should be
Découvrez des centaines de modules disponibles

Comment 1

[Jean Collings]

Thanks for the flag. The inclusion of & is a problem with our snippet service so we are working on fixing that. Will let you know when it's completed.

Comment 2

[Pascal Chevrel:pascalc]

Please note that there is not just typography errors, spaces were removed in the second snippet and this can be fixed now, doesn't it?

Comment 3

[Osmose [:osmose, :mkelly]]

What Jean means is that right now Snippets fails to save a snippet when you include an unescaped & because the snippet code has to be well-formed XML. For some reason, including the   is causing our XML validation to fail, so this needs some dev attention to figure out why it's failing and how we can include it.

(And unfortunately these particular snippets aren't winning the priority battle in my queue; giorgos might have better luck.)

Let's assume this won't get fixed for at least a few days, possibly longer. Would you rather disable the snippet, replace the snippet text with an alternative, or keep the snippet up as is?

Comment 4

[Pascal Chevrel:pascalc]

right, but the second snippet does not have   in it, it is the spaces that were removed in between the words 'centainesde'  should de 'centaines de' and 'modulesdisponibles' should be 'modulesdisponibles'.

Comment 5

[Théo Chevalier]

(In reply to Michael Kelly [:mkelly,:Osmose] from comment #3)
> What Jean means is that right now Snippets fails to save a snippet when you
> include an unescaped & because the snippet code has to be well-formed XML.
> For some reason, including the   is causing our XML validation to fail,
> so this needs some dev attention to figure out why it's failing and how we
> can include it.
> 
> (And unfortunately these particular snippets aren't winning the priority
> battle in my queue; giorgos might have better luck.)
> 
> Let's assume this won't get fixed for at least a few days, possibly longer.
> Would you rather disable the snippet, replace the snippet text with an
> alternative, or keep the snippet up as is?

For now you can just replace   with a regular space character + add the missing spaces. We can add the non-breaking spaces in a few days.

Comment 6

[Pascal Chevrel:pascalc]

s/should be 'modulesdisponibles'/should be 'modules disponibles'

Comment 7

[Jean-Bernard Marcon]

Thanks for any quick action to fix this.
I am a little surprised this snippet text has been pushed in production without any review by l10n French team. 
Also, I don't care much for "the snippet service", I do care much for the French user being hurt by sloppy messages. In case of doubt, just do not release, please.

Comment 8

[Giorgos Logiotatidis [:giorgos]]

Android snippets (JSONSnippets) do not have a problem with   character as they don't need to be valid XML. 

I just tried with complémentaires ? in my test environment and it's acceptable input and displays fine in nightly.

So this snippet can be fixed by adding   and spaces where needed. Doing so unfortunately hits the 140 character limit because ' ' gets counted as 6 instead of 1 characters. So we'll have to rephrase the snippet or increase the limit until we come up with a more sophisticated fix.

Anyway 140 characters limit does not guarantee that the snippet will display correctly. See my attachment of the original snippet in Fennec Nightly on my Nexus 4 for details.

Comment 9

[Giorgos Logiotatidis [:giorgos]]

Attachment: Screenshot_2014-05-13-10-05-21.png

Some text is hidden in Nexus 4, fennec nightly, although snippets is less than 140 chars.

Comment 10

[Giorgos Logiotatidis [:giorgos]]

I did a bit more research on the issue:

 - It appears that there is a special unicode character reserved for this use U+202F (Narrow no-break space) From https://en.wikipedia.org/wiki/Non-breaking_space 

 - This character displays as expected in Fennec Release and Fennec Nightly.

 - Using this character solves the character limit problem.

I updated the snippet using this character.

Jean, do you think that using this character is an acceptable solution for you?

Comment 11

[Jean Collings]

Theo, Jean-Bernard and Pascal I have disabled the snippet until we resolve this issue. Can you please help me reduce this to 140 characters if possible? It is currently at 144:

Vous adorez les modules complémentaires? Découvrez des centaines de modules disponibles dès maintenant pour la version Android de Firefox. 

(Note: We will make sure that there is a non-breaking space before the question mark and period).

Comment 12

[Théo Chevalier]

(In reply to Jean Collings from comment #11)
> Theo, Jean-Bernard and Pascal I have disabled the snippet until we resolve
> this issue. Can you please help me reduce this to 140 characters if
> possible? It is currently at 144:
> 
> Vous adorez les modules complémentaires? Découvrez des centaines de modules
> disponibles dès maintenant pour la version Android de Firefox. 
> 
> (Note: We will make sure that there is a non-breaking space before the
> question mark and period).

Hi Jean,
Thanks for taking care of it, but please, do not add a non-breaking space before periods, this is totally wrong in French.

Here is a shortened version:

Vous adorez les modules complémentaires ? Découvrez les nombreux modules de Firefox pour Android.


Tell me if that's okay for you. The updated version should fit in the UI too.

Thanks!

Comment 13

[Jean Collings]

Thank you for highlighting that Theo and for the updated copy. I've went ahead and pushed it live.

Comment 14

[Théo Chevalier]

Reopening because I can still see the old snippet on GA. I know there is some cache, but it's been 24hrs

Comment 15

[Jean Collings]

Hi Theo,
It actually ranges from 24-48 hours but just let me know when you do see the correct form. Thanks.

Comment 16

[Jean-Bernard Marcon]

(In reply to Jean Collings from comment #15)
> Hi Theo,
> It actually ranges from 24-48 hours but just let me know when you do see the
> correct form. Thanks.

Thanks all, it seems to be fixed now (I suppose there is nothing to do regarding "portrait" view cropping the message ?)

Portrait view https://lut.im/1dzoAK7o/t9jxCl30
Landscape view https://lut.im/ToRVANfS/gbmVbDcv

Comment 17

[Théo Chevalier]

(In reply to Jean-Bernard Marcon from comment #16)
> (In reply to Jean Collings from comment #15)
> > Hi Theo,
> > It actually ranges from 24-48 hours but just let me know when you do see the
> > correct form. Thanks.
> 
> Thanks all, it seems to be fixed now (I suppose there is nothing to do
> regarding "portrait" view cropping the message ?)
> 
> Portrait view https://lut.im/1dzoAK7o/t9jxCl30
> Landscape view https://lut.im/ToRVANfS/gbmVbDcv

Hm. Well, we can shorten a bit more:

Vous adorez les modules complémentaires ? Découvrez ceux de Firefox pour Android.

What do you think Jean-Bernard?

Comment 18

[Jean-Bernard Marcon]

(In reply to Théo Chevalier [:tchevalier] from comment #17)
> (In reply to Jean-Bernard Marcon from comment #16)
> > (In reply to Jean Collings from comment #15)
> > > Hi Theo,
> > > It actually ranges from 24-48 hours but just let me know when you do see the
> > > correct form. Thanks.
> > 
> > Thanks all, it seems to be fixed now (I suppose there is nothing to do
> > regarding "portrait" view cropping the message ?)
> > 
> > Portrait view https://lut.im/1dzoAK7o/t9jxCl30
> > Landscape view https://lut.im/ToRVANfS/gbmVbDcv
> 
> Hm. Well, we can shorten a bit more:
> 
> Vous adorez les modules complémentaires ? Découvrez ceux de Firefox
> pour Android.
> 
> What do you think Jean-Bernard?

or some other shorter solution:

"Découvrez des dizaines de modules complémentaires pour votre Firefox avec Android !"

= 89 chars non-breaking space included, your suggestion is 2 chars shorter but I would prefer avoiding "ceux de" which is perfect grammatically but compels user's mind to search for a fraction of second what "ceux" is subtitute for)

Comment 19

[Jean Collings]

Looping in Deb and Margaret - looks like 140 characters is too much...in the portrait view the snippet message gets cut off. Can you please let us know the correct character count or possibly fix it so that it'll reduce font size to fit 140 or less characters? Let us know, thanks!

Comment 20

[Deb Richardson [:dria] (plz NEEDINFO)]

I'm going to NEEDINFO ibarlow here, as I think there are three possible approaches:

1) We reduce the # of characters to somewhat less than 140.  The trick is that we're not sure just how few characters we need as display changes on different devices.
2) We automatically reduce font size when all characters won't fit at default size.
3) We let the snippet banner expand upwards by an extra line (which may be tricky).

Are there other possibilities?

Comment 21

[Théo Chevalier]

The problem is not the number of characters, it's the lack of testing opportunities from localizers.
With long words such as "complémentaires", it's easy to get the word on a new line in portrait view.

Comment 22

[Ian Barlow (:ibarlow)]

As Théo said, this doesn't really sound like a design issue, it sounds like a testing issue. I'd rather we figure out how to get people to check the appearance of snippet messages before they go live, rather than preemptively going and changing the design. 

Un-needinfoing myself for now.

Comment 23

[Deb Richardson [:dria] (plz NEEDINFO)]

Clearing the needinfo on me as this sounds like something the Snippets team needs to sort out.  Re-add me if there's a specific question or something I can help with!

Comment 24

[Giorgos Logiotatidis [:giorgos]]

We're now using non breaking spaces in french snippets and the errors of comment #0 are now fixed. Thanks for reporting!