Closed
Bug 1009291
Opened 12 years ago
Closed 12 years ago
Bug 926922 broke non-sps builds
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: stevensn, Assigned: stevensn)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.15 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
Bug 926922 broke non-sps builds
,
2:09.50 from /home/ssinger/build-out.ppc64/xpcom/base/Unified_cpp_xpcom_base0.cpp:54:
2:09.50 ../../dist/include/GeckoProfiler.h:97:37: error: ‘ProfilerBacktrace’ has not been declared
|
Assignee | |
Comment 1•12 years ago
|
||
Moving the forward declaration up fixes the error
|
|
Assignee | |
Comment 2•12 years ago
|
||
remove extra blank line
Attachment #8421391 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8421396 -
Flags: review?(bgirard)
|
||
Updated•12 years ago
|
Attachment #8421396 -
Flags: review?(bgirard) → review+
|
||
Comment 4•12 years ago
|
||
Hi,
could you provide a Try link. Suggestions for what to run if you haven't
yet can be found here:
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 6•12 years ago
|
||
Assignee: nobody → steve
Keywords: checkin-needed
|
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•