1009297 - [flame] TARGET_USES_ION is not defined

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Sotaro Ikeda [:sotaro]]

On MozBuild, TARGET_USES_ION is not defined in device/qcom/msm8610/BoardConfig.mk. By this, when we flash flame device by "./flash.sh", video decoding and camera recording do not work.

Comment 1

[Sotaro Ikeda [:sotaro]]

By definig TARGET_USES_ION, I confirmed that video decoding and camera recording works by "./flash.sh".

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: link to pull request

I confirmed that the problem is fixed on master flame by applying the patch.

Comment 3

[Sotaro Ikeda [:sotaro]]

Actually in video decoding case, omx_vdec::allocate_input_buffer() was failed because of lacking USE_ION definition. Actual place was the following.

>         pmem_fd = open (MEM_DEVICE,O_RDWR);

https://www.codeaurora.org/cgit/quic/la/platform/hardware/qcom/media/tree/mm-video-v4l2/vidc/vdec/src/omx_vdec_msm8974.cpp?h=jb_3.2_rb5.56#n4668

Comment 4

[Sotaro Ikeda [:sotaro]]

mwu, is there a change how to merge pull request? I could not merge pull request from github pare any more.

Comment 5

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #4)
> mwu, is there a change how to merge pull request? I could not merge pull
> request from github pare any more.

It seems depend on the repository. I still can see "mrege button" on "gonk-misc".

Comment 6

[Sotaro Ikeda [:sotaro]]

Nominate to "b2g 1.4+". Without this change, when we flash whole MozBuild ROM with "./flash.sh", flame device can not do playback video and camera recording.

Comment 7

[Michael Wu [:mwu]]

I still see the merge button. I don't know if there's been changes.

Comment 8

[Ryan VanderMeulen (PTO, back July 27)]

Master: https://github.com/mozilla-b2g/device-flame/commit/7dffe28a30abbcda13b0ba2d7a933d22bd82f9d7

Comment 9

[Sotaro Ikeda [:sotaro]]

(In reply to Michael Wu [:mwu] from comment #7)
> I still see the merge button. I don't know if there's been changes.

Hmm, it's wired.

Comment 10

[Sotaro Ikeda [:sotaro]]

Clear "1.4?", v1.4 flame used master branch of "device-flame".

> <project name="device-flame" path="device/t2m/flame" remote="b2g" revision="master"/>