1009327 - Add "manual connect" to Android about:devices page

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Add "manual connect" to Android about:devices page. r=mfinkle

Still no styling.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8421439 [details] [diff] [review]
Add "manual connect" to Android about:devices page. r=mfinkle

>diff --git a/mobile/android/chrome/content/aboutDevices.js b/mobile/android/chrome/content/aboutDevices.js

>+  _prefsBranch: Services.prefs.getBranch("browser.casting."),

>+    let manual = document.getElementById("manual");
>+    manual.addEventListener("submit", (evt) => {
>+      this.connectManually(evt);
>+    }, false);

You're using a <form> which might have some side effects, one of which might be the need to preventDefault, but you could just use a <div> for containment and styling, and attach an event to the button itself. And use a <button>

>+    let fixedTarget = {};
>+    fixedTarget.target = "roku:ecp";
>+    fixedTarget.location = "http://" + ip + ":8060";

We should think about creating a <select> list, with "Roku" for now, and use it to pick the target and port. We'll likely add "Chromecast" (maybe) and "Netcast" when support for those lands.

>+    this._prefsBranch.setCharPref("fixedTargets", JSON.stringify(fixedTargets));

Not sure we need to hold the prefsBranch as a data member for just this usage. You could just make it local to this method.

Do you want to take a swing at not using a <form> and adding a <select> for the initial landing? I have more feedback on making this work a bit nicer, but that can wait for v2.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 8421439 [details] [diff] [review]
> Add "manual connect" to Android about:devices page. r=mfinkle
> 
> >diff --git a/mobile/android/chrome/content/aboutDevices.js b/mobile/android/chrome/content/aboutDevices.js
> 
> >+  _prefsBranch: Services.prefs.getBranch("browser.casting."),
> 
> >+    let manual = document.getElementById("manual");
> >+    manual.addEventListener("submit", (evt) => {
> >+      this.connectManually(evt);
> >+    }, false);
> 
> You're using a <form> which might have some side effects, one of which might
> be the need to preventDefault, but you could just use a <div> for
> containment and styling, and attach an event to the button itself. And use a
> <button>

I did wonder about this, but followed some existing stuff from aboutFeedback.  Happy to update.
 
> >+    let fixedTarget = {};
> >+    fixedTarget.target = "roku:ecp";
> >+    fixedTarget.location = "http://" + ip + ":8060";
> 
> We should think about creating a <select> list, with "Roku" for now, and use
> it to pick the target and port. We'll likely add "Chromecast" (maybe) and
> "Netcast" when support for those lands.

That's a good idea.
 
> >+    this._prefsBranch.setCharPref("fixedTargets", JSON.stringify(fixedTargets));
> 
> Not sure we need to hold the prefsBranch as a data member for just this
> usage. You could just make it local to this method.
> 
> Do you want to take a swing at not using a <form> and adding a <select> for
> the initial landing? I have more feedback on making this work a bit nicer,
> but that can wait for v2.

This patch is so small, might as well suggest what we eventually want and I'll incorporate more.

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Add "manual connect" to Android about:devices page. r=mfinkle

Take two; I'll add a part 2 with fixed-but-not-found target display.

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/d71a36a85151

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d71a36a85151

Comment 7

[Flaviu Cos]

I can not add my Roku device manually; I filled in the IP address field with Roku's valid IP address, I tapped on the 'Connect manually' button and nothing happens.
The following log is outputted in logcat when I tap on the 'Connect manually' button: E/GeckoConsole(7901): aboutDevices :: Updating device list with 0 services.

Comment 8

[Aaron Train [:aaronmt]]

Please file a new bug and block it against this.