1009335 - PJS: Propagate errors from ParallelSafetyAnalysis when compiling OMT

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Shu-yu Guo [:shu]]

When compiling OMT, errors from ParallelSafetyAnalysis get swallowed, so we end up trying to compile failed scripts over and over.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Propagate errors from ParallelSafetyAnalysis when compiling off main thread.

Comment 2

[Brian Hackett [Laid off!]]

Comment on attachment 8421446 [details] [diff] [review]
Propagate errors from ParallelSafetyAnalysis when compiling off main thread.

Review of attachment 8421446 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but I'd like to see a new patch as the comments below will require a fair amount of this to be restructured.

::: js/src/jit/Ion.cpp
@@ +1360,5 @@
>      if (graph.entryBlock()->info().executionMode() == ParallelExecution) {
>          AutoTraceLog log(logger, TraceLogger::ParallelSafetyAnalysis);
> +        // Compilation of PJS kernels only happens with IonBuilders.
> +        MOZ_ASSERT(!mir->compilingAsmJS());
> +        ParallelSafetyAnalysis analysis(*reinterpret_cast<IonBuilder *>(mir), graph);

Hmm, can you move abortReason_ from IonBuilder to MIRGenerator to avoid this cast?

::: js/src/jit/ParallelSafetyAnalysis.cpp
@@ +387,5 @@
> +
> +                    // Set the abort reason on the top IonBuilder disable, so
> +                    // that we may propagate the error correctly in case we
> +                    // are being compiled off-thread.
> +                    return builder_.topIonBuilder().disable();

The MIR generator passed in will be the top IonBuilder (the builders for inlined frames only ever exist on the stack, anyhow), so there's no need to walk the parents here.

Comment 3

[Shu-yu Guo [:shu]]

Attachment: Propagate errors from ParallelSafetyAnalysis when compiling off main thread.

Applied comments.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2cb01880f06f