10094 - do not do extern C over include files

Status: VERIFIED WORKSFORME

(Core :: Graphics: ImageLib, defect, P3)

Description

[Dan.Oscarsson]

File: mozilla/modules/libimg/png/png.h

When you do extern C over include files you may
do extern C over overloaded C routines.
With Sun Wokshop 5.0 there is C++ adapted standard include
files with such overloads. And teherfore can the file not
be compiled.

Below fixed just so that it compiles, should really be fixed
by extern C in the needed included files instead.

*** png.h.org   Sun Jul 18 11:50:28 1999
--- png.h       Sun Jul 18 11:50:51 1999
***************
*** 94,102 ****
  #ifndef _PNG_H
  #define _PNG_H

- #ifdef __cplusplus
- extern "C" {
- #endif /* __cplusplus */

  /* This is not the place to learn how to use libpng.  The file libpng.txt
   * describes how to use libpng, and the file example.c summarizes it
--- 94,99 ----
***************
*** 110,115 ****
--- 107,116 ----
  /* include all user configurable info */
  #include "pngconf.h"

+ #ifdef __cplusplus
+ extern "C" {
+ #endif /* __cplusplus */
+
  /* This file is arranged in several sections.  The first section contains
   * structure and type definitions.  The second section contains the external
   * library functions, while the third has the internal library functions,

Comment 1

[pnunn]

in pnglib:

Comment 2

[Eli Goldberg]

Per e-mail from Greg, he has relinquished PNG component ownership; thus, 
reassigning assigned bugs to ImageLib owner.

Comment 3

[neeti]

Moving to m17

Comment 4

[neeti]

Moving to m18

Comment 5

[Glenn Randers-Pehrson]

The recommended patch was applied to libpng's png.h in mid-August 1999,
at version 1.0.3b.

Comment 6

[Rich Burridge]

To help us focus on the Sun specific bugs when we do a bug query, I'm
moving this one to Platform/OS category of All/All where it belong.

Comment 7

[Rich Burridge]

It would help if I actually did what I said I was going to do. Transferring 
to All/All.

Comment 8

[pnunn]

All pnunn bugs reassigned to Pav, who is taking over
the imglib.

Comment 9

[Stuart Parmenter]

i build with workshop 5 and forte 6 all the time and havn't seen this.. marking 
worksforme

Comment 10

[Terri Preston]

Coding issue, therefore marking verified

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0252a3ec37a5
[fenix] Update run-visual-metrics.py with mozilla-central changes. (https://github.com/mozilla-mobile/fenix/pull/10094)