1009401 - Update search app to align with new homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect, P1)

Description

[Francis Djabri [:djabber]]

The search app feels as if it has a very different design language from the new home screen. This bug is about aligning the two. 

The UX spec also introduces some new behaviors around saving state. In usability tests, users are generally somewhat surprised to return to anything except the home grid when pressing the home button. The spec dictates that the user should return to the home screen layout when pressing home, but introduces some state-saving behavior so that the user can return to previous searches.

Comment 1

[Przemek Abratowski [:przemek] UX]

Attachment: Search_App_v0_2.pdf

Adding NEW IxD and Visual Design spec for the Rocket Bar search Results page.

Comment 2

[Przemek Abratowski [:przemek] UX]

Attachment: search_results_spec.jpg

Adding NEW IxD and Visual Design spec for the Rocket Bar search Results page.

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/19570

This updates to the new visual spec

The color picker isnt currently implemented (was a nice to have), this also doesnt have animations, my first runs with animations ran terribly so I think its best to file a follow up address those.

The affects the visuals on full rocketbar mode as well, since thats 2.1 I am considering any 2.0 changes to take precedent over 2.1 designs.

Comment 4

[Dale Harvey (:daleharvey)]

And to explain what the patch does, we need to cover the homescreen icons but still have the wallpaper, this reuses the existing rocketbar backdrop giving it the wallpaper background and makes the search app transparent, in general I am wary of transparent applications however I did a first run that put the wallpaper on the search app, this was extremely complicated as it required making the search app fullscreen, this patch was far simpler and performs well so far

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8427655 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19570

Nice work! Just making a note that this does cause some issues with the E.me search background provider, but I think that's ok as we have some other configuration bugs filed to solve this.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8427655 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19570

BTW you have 2 fallen tests.

Comment 7

[Dale Harvey (:daleharvey)]

Addressed the review comments (and fixed tests, missing include)

Thanks

https://github.com/mozilla-b2g/gaia/commit/b6d8cd7e15af9028b4d54f03ae4e1c5ac1f7e21d

Comment 8

[Dale Harvey (:daleharvey)]

apologies, assumed alives comment about searchWindow meant it was already implemented, needed to add searchWindow to the CLASS_LIST

https://github.com/mozilla-b2g/gaia/commit/ec3cee3d8a0c1c3c7ef1cecd8bf9577b7ecb0bce

Comment 9

[Stephany Wilkes]

Comment on attachment 8427655 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19570

This should go through ui-review? with Eric Pang.

Comment 10

[Stephany Wilkes]

Comment on attachment 8427655 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19570

And flagging Francis for IxD review, so both IxD and VxD reviews are completed here.

Comment 11

[Eric Pang [:epang] UX]

Comment on attachment 8427655 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19570

Hi Dale, I reviewed the current build and found the following issues, can you take a look?

1. RB search labels should have 3 lines of text (and larger vertical spacing between icons - extra 20px as seen in spec).

2. Search Result icons are a little small compared to the homescreen (they should be 64x64px)

3. Search Result icons are blurry 

4. Labels are too small - this is a homescreen issue (when going from 3 to 4 grid the label size shouldn’t change)  If updated in the homescreen will the RB search page be updated as well?

5. Go button is missing in RB

6. Search suggestions colour should be #00aacc (text) and #666666 (bullets).

7. Entering RB Search motion - Based on comment 3 is it the animation that isn’t running good?  Can you let me know, cause if that’s the case we can try something else out (maybe something similar to entering edit mode on homescreen - cause that seems to work really smoothly)

8. some search results icons seem to be missing

Please let me know if you have any questions, thanks Dale!

Comment 12

[Eric Pang [:epang] UX]

Reopening bug because of comments above

Comment 13

[Kevin Grandon :kgrandon]

Let's file two new bugs here to ease tracking/uplift tracking if that's ok.

One for stuff specific to the search app, and one for the grid rendering which is shared between homescreen/search/collections. I can help file these bugs if needed.

Comment 14

[Francis Djabri [:djabber]]

Comment on attachment 8427655 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19570

In addition to Eric's comments, there are a few discrepancies between the latest build and the latest spec (v0.5):

1) The spec states that if the user taps the close button, the search field should be cleared and the user should be returned to the home screen. The next time the user accesses the search app, it should be in the empty state (as the search field was cleared). In the build, however, the previous text remains and is shown highlighted. 

2) Conversely, if the user opens the search app and the text field has not been cleared, it should show the previous text AND results. The build, however, only shown the text highlighted, but no results. According to the spec, the text should not be highlighted and the search results should be shown.

Comment 15

[Jason Smith [:jsmith]]

Leaving needinfo here to make sure that bugs get filed for issues mentioned above.

Comment 16

[Eric Pang [:epang] UX]

Opened separate bugs here:

Update search app to align with new home screen
https://bugzilla.mozilla.org/show_bug.cgi?id=1023819

Homescreen label size should remain the same
https://bugzilla.mozilla.org/show_bug.cgi?id=1023824

Comment 17

[Dale Harvey (:daleharvey)]

Clearing neeinfo with new bugs

Comment 18

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

https://moztrap.mozilla.org/manage/case/13927/
https://moztrap.mozilla.org/manage/case/13925/
https://moztrap.mozilla.org/manage/case/13926/