Closed Bug 1009464 Opened 10 years ago Closed 10 years ago

Replace outdated icons and add missing ones in Contacts.

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.0, b2g-v2.0 fixed)

Status:
VERIFIED FIXED
Milestone:
2.0 S2 (23may)
Project Flags:
feature-b2g 2.0
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: arnau, Assigned: paco)

References

Details

Attachments

(3 files)

Assets. PNG. Contacts
39.80 KB, application/zip
Details
patch in github
46 bytes, text/x-github-pull-request
arcturus
: review+
Details | Review
dual-sim-contact.png
51.69 KB, image/png
Details 
      No description provided.
Assignee: nobody → pacorampas
Summary: Replace outdated icons and add missing ones in Contacts and Dialer. → Replace outdated icons and add missing ones in Contacts.
We are changing the following icons on contacts app:
1- sms.png
2- call.png
3- link.png
4- mail.png
5- location.png
6- icon-fav-button-on.png
7- icon-fav-button-off.png
Blocks: contacts-visual-refr
No longer blocks: dialer-visual-refres
Target Milestone: --- → 2.0 S2 (23may)
Attached file Assets. PNG. Contacts — 
Here I attach the requested icons.
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
Attached file patch in github — 

        Attachment #8426140 -
        Flags: review?(francisco.jordano)

    
    

    
  

      
      
      
      

        Attached image
          
        dual-sim-contact.png
        — 
      

    


  

    
    

    
  
Comment on attachment 8426140 [details] [review]
patch in github

Hei Paco,

great job here!

There is just one thing, in the previous classes we had the |js-sim-indication| class with display:none we have this to hide in the default case of single sim scenarion.

Actually if you get your code and put it into a single device (like hamachi, unagi, etc) you'll see how the long tap indication appears, and it shouldnt.

The multisimbuttonaction (love the name :)), will add a class to the body |has-preferred-sim| that will let you know that you are in a case with more than one sim to select, use the combination of both classes to display the long tap indication.

Thanks!

        Attachment #8426140 -
        Flags: review?(francisco.jordano) → review-

    
    

    
  
> The multisimbuttonaction (love the name :)), will add a class to the body |has-preferred-sim| that will 
> let you know that you are in a case with more than one sim to select, use the combination of both classes > to display the long tap indication.
Ok, I'm going to do it. In 5 minuts new patch :P
Thanks.

    
  

        Attachment #8426140 -
        Flags: review- → review?(francisco.jordano)

    
    

    
  
Nominating for 2.0? since, bug 1013287 that was already 2.0+ has been marked as duplicated of this one.
blocking-b2g: backlog → 2.0?

    
    

    
  
Comment on attachment 8426140 [details] [review]
patch in github

Gracias Paco!

Now working like a charm.

Great job, please merge once travis is green.

        Attachment #8426140 -
        Flags: review?(francisco.jordano) → review+

    
    

    
  
Merged: 467411b47d115c78887f43f1e8fc538e3f2a88fb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Already landed in master so clearing 2.0? flag
blocking-b2g: 2.0? → ---

          status-b2g-v2.0:
          --- → fixed

    
    

    
  
Tested and fine
2.0
Hamachi
Gecko-e4bc303.Gaia-27c85c3
Status: RESOLVED → VERIFIED
QA Contact: lolimartinezcr

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: