1009473 - Polish image list view

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[:Margaret Leibovic]

Right now images are too small, let's remove the padding around them to make them bigger.

Comment 1

[:Margaret Leibovic]

Attachment: Remove padding around list item images

Comment 2

[:Margaret Leibovic]

Attachment: Use lighter gray for item descriptions

This is the color antlam gave me, and it's not used elsewhere in the product, but maybe we should pull it into dimens.xml, or file a follow-up to audit the different shades of gray that we use in the product.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/a84120599214
https://hg.mozilla.org/integration/fx-team/rev/08070d4b85f4

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a84120599214
https://hg.mozilla.org/mozilla-central/rev/08070d4b85f4

Comment 5

[:Margaret Leibovic]

Comment on attachment 8421806 [details] [diff] [review]
Remove padding around list item images

I know we're getting late in the beta cycle, but I think this would be a really nice fix to have before we start promoting hub add-ons in Fx30.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new home panel APIs
User impact if declined: home panel lists look uglier
Testing completed (on m-c, etc.): landed on m-c 5/13
Risk to taking this patch (and alternatives if risky): low risk, style tweaks to dynamic panel lists
String or IDL/UUID changes made by this patch: none

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8421806 [details] [diff] [review]
Remove padding around list item images

it's less 'late' in the beta cycle for mobile as we have two more betas and this is a low risk user-facing style fix on a great new feature so let's take it.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/08251170a2a4
https://hg.mozilla.org/releases/mozilla-aurora/rev/96f87b42c039

https://hg.mozilla.org/releases/mozilla-beta/rev/841a1b085b5b
https://hg.mozilla.org/releases/mozilla-beta/rev/82c33d14844a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/841a1b085b5b
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/82c33d14844a

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Device: LG Nexus 4 (Android 4.4.2)
Builds: 32.0a1 Nightly 05/26 and 31.0a2 Aurora 04/26

Comment 10

[Catalin Suciu [:csuciu]]

Verified fixed on Firefox 30 Beta 8