1009520 - Incorrect quote usage in global/header.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Christophe JAILLET]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140421221237

Steps to reproduce:

Have a muti-lang installation.

Update template/<LANG>/default/global/variables.non.tmpl to use strings with a single quote (') in *bugs* variables

Go on any page


Actual results:

The link to change the language does not appear (at least on FF 29 and IE 8 )


Expected results:

The link should have been displayed.

This is due to the usage of ' instead of " in template/<LANG>/default/global/header.html.tmpl
attach_desc_required:
                    'You must enter a Description for this attachment.',
                component_required:
                    'You must select a Component for this [% terms.bug %].',
                description_required:
                    'You must enter a Description for this [% terms.bug %].',
                short_desc_required:
                    'You must enter a Summary for this [% terms.bug %].',
                version_required:
                    'You must select a Version for this [% terms.bug %].'

This should be updated to use " or escape terms.bug in order to avoid the problem.


Seen on 4.2.9 but I've checked that the code is still the same on trunk.

Comment 1

[Frédéric Buclin]

It's not an incorrect quote usage. Bugzilla doesn't expect someone would use single quotes to replace the word "bug".

Comment 2

[Christophe JAILLET]

Well, in my particular case, I would like to do so.
I'm planning to use bugzilla for something a little different than bug, that is to say "Demande d'évolution", in French. Could be translated to something like "User's request".

Just using "Demande" (i.e. request) could be enough, so my request is a very low priority.
Moreover, I have a French translation installed and I've modified the quotes there.

I agree that "incorrect" is a bit strong, as it is perfectly valid syntax.


But, I thought it could be useful for some-else, was easy to fix and would have no side-effect.
That's why I reported it.


Feel free to close if you don't share my point of view.

Comment 3

[Simon Green]

Attachment: bug1009520-v1.patch

All other occurrences of

grep -rsi "'.*terms.bug.*'"

are okay.

Comment 4

[Simon Green]

To ssh://[e-mail]/bugzilla/bugzilla.git
   526b329..6dbcec0  master -> master