1009535 - [FTE] Ensure that progressbar show steps within limits

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: bug capture

Comment 1

[Fernando Campo (:fcampo)]

I'm fearing a regression here, as I don't remember seeing it two weeks ago.
But I'm checking, and can't see anything merged on FTE related to the steps recently.

Comment 2

[Fernando Campo (:fcampo)]

Last related code is from bug 984404 (commit 34679061271542dd7ece6f1883972490d3d6da34), but it's two months old, and I don't remember seeing this at the time.

Comment 3

[Jason Smith [:jsmith]]

Switching to qawanted to compare behavior on 1.4 vs. 2.0.

Comment 4

[Noemí Freire (:noemi)]

Hi,

Tested on today's (5/14) master and v1.4 builds
*master
Device: Hamachi
BuildId:20140514070958
Gecko: 754c5c0
Gaia: 655a1eb
Platform version: 32.0a1

*v1.4
Device: Hamachi
BuildId: 20140514054004
Gecko: 5cf917c
Gaia: b40103d
Platform version: 30.0

Horizontal scrolling issue only happens on master branch, please see attached some screenshots corresponding to master and v1.4 behavior

Comment 5

[Noemí Freire (:noemi)]

Attachment: 2014-05-14-v1.4_1.png

v1.4 - FTU second to last step

Comment 6

[Noemí Freire (:noemi)]

Attachment: 2014-05-14-v1.4_2.png

v1.4 - FTU last step

Comment 7

[Noemí Freire (:noemi)]

Attachment: 2014-05-14-master1.png

master - FTU second to last step

Comment 8

[Noemí Freire (:noemi)]

Attachment: 2014-05-14-master2.png

master - FTU last step

Comment 9

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

I'll take it as I worked on that scrolling logic two months ago and I think I know what's the issue. Thanks Fernando for the Cc.

Comment 10

[Jason Smith [:jsmith]]

Really ugly, but I don't think I'd hold a release on this.

Comment 11

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #19345 - [FTU] Fix navigation step logic

Comment 12

[Fernando Campo (:fcampo)]

Comment on attachment 8424377 [details] [review]
Pull Request #19345 - [FTU] Fix navigation step logic

Comments on github. Working ok on my tests, but were you able to test it with a DSDS device? I don't have any available at the moment.

It might need some new tests also, so we avoid this situation in the future, by checking the step-state position (I thought that we had some already anyway)

Comment 13

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 8424377 [details] [review]
Pull Request #19345 - [FTU] Fix navigation step logic

Updated the PR, including step-wise navigation bar position tests. Thanks for the feedback!

Comment 14

[Maria Angeles Oteo (:oteo)]

I am not reproducing the bug in latest master build, independently if I register or not in FxA.

Tested on today's (5/14) master
B-184
Device: Hamachi
BuildId:20140601080828
Gecko: 3e5340d
Gaia: 7416a2
Platform version: 32.0a1

Setting qawanted to confirm

Comment 15

[Fernando Campo (:fcampo)]

(In reply to Maria Angeles Oteo (:oteo) from comment #14)
> I am not reproducing the bug in latest master build, independently if I
> register or not in FxA.
> 
> Tested on today's (5/14) master
> B-184
> Device: Hamachi
> BuildId:20140601080828
> Gecko: 3e5340d
> Gaia: 7416a2
> Platform version: 32.0a1
> 
> Setting qawanted to confirm
Just checked with master and that's right, it's working fine.
I guess that this commit did it https://github.com/mozilla-b2g/gaia/commit/d284e6dd794d60b13a9cd4a47490686cd60aceb0

Not sure what to do now :S Should we merge this anyway? on one hand, it makes the code better, and it adds more testing, which is always good. on the other hand, it doesn't solve any existing issue

Comment 16

[Fernando Campo (:fcampo)]

Comment on attachment 8424377 [details] [review]
Pull Request #19345 - [FTU] Fix navigation step logic

After an offline conversation, we think it's better not to lose this work, so we're gonna mutate the bug's name. Please do the same with the commit's name, and merge when travis gets green (I just relaunched a failed test)

Comment 17

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks Fernando! Landed on master:
https://github.com/mozilla-b2g/gaia/commit/81d24710da6428393e016e78b6816617d60ed7b2