1009552 - [rtl] Network error title text overlaps the Info icon

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Ada [:adalucinet]]

Attachment: Image showing this issue

Reproducible on the latest Nightly 32.0a1 (BuildID: 20140512030202): 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0

STR:
1. Launch latest Nightly ar build.
2. In the Menu bar select Tools -> Options -> Advanced and go to Network tab.
3. Click on Settings and for Manual proxy configuration add an invalid proxy (Eg: HTTP Proxy = 12345678910 and Port = 65535)
4. Disable network connection.
5. Enter an invalid URL in the awesome bar (Eg: "a...b" or "www.thisisnotavalidaddres.com")

Expected results: "The proxy server is refusing connections" network error message is properly displayed.

Actual results: "The proxy server is refusing connections" network error message is not properly displayed.

Notes:
1. Not reproducible with builds before the fix from bug 982347 - not a regression.
2. Reproducible on all platforms: Windows 7 x64, Ubuntu 13.10 x32 and Mac OS X 10.9.2
3. Not reproducible with en-US nor he builds.
4. I think this issue is based on the Info icon placement for RTL builds as per http://goo.gl/m5rJEH. Any thoughts?

Comment 1

[:Gijs (he/him)]

Once again, I'm confused:

"1. Not reproducible with builds before the fix from bug 982347 - not a regression."

If it wasn't reproducible before then, that sounds like bug 982347 regressed this.

This can probably also be reproduced by using the force rtl add-on with a regular en-US nightly.

Comment 2

[Valentin Tsatskin [:vt]]

Attachment: rtl.not.working.png

I can't seem to get the "Force RTL" addon to force the error pages into RTL, so I'm blocked on testing if any changes will have an effect. Not sure if this is a bug with the addon or the browser.

Comment 3

[Valentin Tsatskin [:vt]]

(In reply to Valentin Tsatskin [:vt] from comment #2)
> Created attachment 8423276 [details]
> rtl.not.working.png
> 
> I can't seem to get the "Force RTL" addon to force the error pages into RTL,
> so I'm blocked on testing if any changes will have an effect. Not sure if
> this is a bug with the addon or the browser.

As per the discussion on IRC, the "dir" attribute on body needs to be manually changed to test this: http://hg.mozilla.org/mozilla-central/annotate/d773600f10bd/browser/base/content/aboutneterror/netError.xhtml#l268

Comment 4

[Valentin Tsatskin [:vt]]

Attachment: 1009552.patch

Comment 5

[Valentin Tsatskin [:vt]]

Attachment: screenshot.fixed.png

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8423288 [details] [diff] [review]
1009552.patch

Review of attachment 8423288 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, sorry for the misguided recommendation in the earlier bug.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Yikes, can't believe this almost sat here for a week without being checked in. Thanks for setting the flag Valentin.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2d518ae751f6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2d518ae751f6

Comment 10

[Ada [:adalucinet]]

Verified as fixed with latest Nightly AR build (Build ID: 20140522030204) on:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Mozilla/5.0 (X11; Linux i686; rv:32.0) Gecko/20100101 Firefox/32.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0