1009565 - Triggering arbitrary jobs gets branch wrong

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

In http://hg.mozilla.org/build/buildapi/file/default/buildapi/scripts/selfserve-agent.py#l614

we create strip off the "-selfserve" to create real_branch, and refer to that in the SQL query. However, we don't pass real_branch into db.execute(), so :real_branch ends up being unset, and we end up with branch = NULL in the database.

Comment 1

[John Zeller [:zeller]]

Attachment: bug1009565.patch

Added real_branch to selfserve-agent.py

Comment 2

[Chris AtLee [:catlee]]

Comment on attachment 8422027 [details] [diff] [review]
bug1009565.patch

Review of attachment 8422027 [details] [diff] [review]:
-----------------------------------------------------------------

itym real_branch=real_branch, since the parameter is called :real_branch

Comment 3

[John Zeller [:zeller]]

Attachment: bug1009565.patch

Opps! Here you go!

Comment 4

[Hal Wine [:hwine] use NI!]

Comment on attachment 8422070 [details] [diff] [review]
bug1009565.patch

https://hg.mozilla.org/build/buildapi/rev/8e291c17c8b6

Comment 5

[John Zeller [:zeller]]

Reopened till deployed. Was prematurely closed

Comment 6

[Chris AtLee [:catlee]]

are we waiting for anything before deploying?

Comment 7

[John Zeller [:zeller]]

(In reply to Chris AtLee [:catlee] from comment #6)
> are we waiting for anything before deploying?

Nope! Deploying now

Comment 8

[John Zeller [:zeller]]

Attachment: versionbump.patch

Comment 9

[Hal Wine [:hwine] use NI!]

Comment on attachment 8431929 [details] [diff] [review]
versionbump.patch

lgtm: r+ 

https://hg.mozilla.org/build/buildapi/rev/ace9bb8c2267

Comment 10

[John Zeller [:zeller]]

All deployed and tested! Additionally, pending/running jobs are now showing up on TBPL as well. Seems this was the issue effecting bug 981825

Comment 11

[Ed Morley [:emorley]]

That's great - thank you :-)

Comment 12

[John Zeller [:zeller]]

(In reply to Ed Morley [:edmorley UTC+0] from comment #11)
> That's great - thank you :-)

No problem!