1009589 - Prevent matches against /^Exception:$/ since it will never return useful bug suggestions

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=39572018&tree=Mozilla-Inbound

{
07:42:02     INFO -  Downloading/unpacking mock
07:42:02     INFO -    Error <urlopen error timed out> while getting http://pypi.pub.build.mozilla.org/pub/mock-1.0.1.tar.gz (from http://pypi.pub.build.mozilla.org/pub/)
07:42:02     INFO -  Exception:
07:42:02    ERROR -  Traceback (most recent call last):
07:42:02     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/pip-0.8.2-py2.7.egg/pip/basecommand.py", line 130, in main
07:42:02     INFO -      self.run(options, args)
07:42:02     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/pip-0.8.2-py2.7.egg/pip/commands/install.py", line 223, in run
07:42:02     INFO -      requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
07:42:02     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/pip-0.8.2-py2.7.egg/pip/req.py", line 917, in prepare_files
07:42:02     INFO -      self.unpack_url(url, location, self.is_download)
07:42:02     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/pip-0.8.2-py2.7.egg/pip/req.py", line 1023, in unpack_url
07:42:02     INFO -      return unpack_http_url(link, location, self.download_cache, only_download)
07:42:02     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/pip-0.8.2-py2.7.egg/pip/download.py", line 429, in unpack_http_url
07:42:02     INFO -      resp = _get_response_from_url(target_url, link)
07:42:02     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/pip-0.8.2-py2.7.egg/pip/download.py", line 458, in _get_response_from_url
07:42:02     INFO -      resp = urlopen(target_url)
07:42:02     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/pip-0.8.2-py2.7.egg/pip/download.py", line 84, in __call__
07:42:02     INFO -      response = urllib2.urlopen(self.get_request(url))
07:42:02     INFO -    File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
07:42:02     INFO -      return _opener.open(url, data, timeout)
07:42:02     INFO -    File "/usr/lib/python2.7/urllib2.py", line 400, in open
07:42:02     INFO -      response = self._open(req, data)
07:42:02     INFO -    File "/usr/lib/python2.7/urllib2.py", line 418, in _open
07:42:02     INFO -      '_open', req)
07:42:02     INFO -    File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
07:42:02     INFO -      result = func(*args)
07:42:02     INFO -    File "/usr/lib/python2.7/urllib2.py", line 1207, in http_open
07:42:02     INFO -      return self.do_open(httplib.HTTPConnection, req)
07:42:02     INFO -    File "/usr/lib/python2.7/urllib2.py", line 1177, in do_open
07:42:02     INFO -      raise URLError(err)
07:42:02     INFO -  URLError: <urlopen error timed out>
07:42:02     INFO -  Storing complete log in /home/cltbld/.pip/pip.log
07:42:02    ERROR - Return code: 2
}

Resultant TBPL excerpt/summary:
{
Exception:
Exceeded max bug suggestions (97 bugs found)Traceback (most recent call last):
URLError: <urlopen error timed out>
Return code: 2
Error running install of package, /builds/slave/test/build/venv/bin/pip install --download-cache /builds/slave/test/build/venv/cache --no-index --find-links http://pypi.pvt.build.mozilla.org/pub --find-links http://pypi.pub.build.mozilla.org/pub mock!
Running post_fatal callback...
Exiting -1
}

Now the noisy log output will be fixed by 1003729, but in the meantime let's just tweak the regexp, so we don't match if the line ends after the colon.

Comment 1

[Ed Morley [:emorley]]

Attachment: Prevent matching against unhelpful exception log output

Made the same tweak to Error too; from what I can tell searching Bugzilla summaries it is always proceeded by a space too.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8421732 [details] [diff] [review]
Prevent matching against unhelpful exception log output

++

Comment 3

[Ed Morley [:emorley]]

Thank you :-)

remote:   https://hg.mozilla.org/webtools/tbpl/rev/c09a128ea1b4

Comment 4

[Ryan VanderMeulen [:RyanVM]]

In production :)