1009654 - In Remember Password doorhanger menu, "Not Now" has awkwardly-placed "x" (close button) and becomes unreadable when hovered

Status: RESOLVED DUPLICATE of bug 1007300

(Firefox :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit any login page, e.g.
      https://wiki.mozilla.org/index.php?title=Special:UserLogin
 2. Type any username/password, e.g. a/a
 3. Click the key in URLbar to open Remember Password doorhanger, if it's not already open.
 4. Click the downarrow to the right of "Remember Password" button
 5. Hover the second entry, "Not Now"

ACTUAL RESULTS:
The "Not Now" menu entry has an "x" close button about halfway across the menu (odd place for it), and the text becomes unreadable when you hover it, because the text changes color but the background does not.

32.0a1 (2014-05-10)
Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0

Regression range:
{
Last good revision: b836d89be72b (2014-04-25)
First bad revision: 0e91262606a6 (2014-04-26)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b836d89be72b&tochange=0e91262606a6
}

Before the regression, there was no "x" button, and the background of the menu entry *would* change color when hovered, so the text remained readable.

Comment 1

[Daniel Holbert [:dholbert]]

Not sure offhand what caused this; CC'ing dao, who had a checkin that mentioned close buttons (Bug 865826), and mdeboer, who had a checkin that mentioned panel-menu buttons (Bug 1000744).

Hoping they might be able to determine what's likely to have caused this.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screencast

Comment 3

[:Gijs (he/him)]

How up to date is your nightly? I would hope that bug 1007300 fixed this...

Comment 4

[Daniel Holbert [:dholbert]]

My nightly was from 5/10. (which is a few days out of date, I suppose)

I've now updated, and now I get different results, matching bug 1007300's description. (I only see the close button in the menu.)

Since that bug's patch was merged to central in the last 12 hours, I'm guessing the fix isn't in today's nightly but will be in tomorrow's.

Comment 5

[Daniel Holbert [:dholbert]]

Yeah, now I get the expected menu-entry text, with no close button, which I think is what's expected.
32.0a1 (2014-05-15)

Resolving as FIXED by bug 1007300.