1009745 - [traceback] Bad translation in locale "pt-BR"

Status: RESOLVED FIXED

(support.mozilla.org :: Code Quality, task, P1)

Description

[Ricky Rosario [:rrosario, :r1cky]]

The badge award task has the following code to create the subject of the email:

    subject = _("You were awarded the '{title}' badge!".format(
            title=_(award.badge.title, 'DB: badger.Badge.title')))

That string should be unicode.
The gettext call shouldn't wrap around the formatting of the string.


See:
https://errormill.mozilla.org/support/support/group/155183/

Traceback:

Bad translation in locale "pt-BR"

Stacktrace (most recent call last):

  File "kitsune/sumo/email_utils.py", line 40, in wrapper
    return f(locale, *args, **kwargs)
  File "kitsune/kbadge/tasks.py", line 20, in _make_mail
    title=_(award.badge.title, 'DB: badger.Badge.title')))

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/kitsune/pull/1968

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/294b081fe9fabb00d73153c3bd59366c18b4abdc

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod.