Closed Bug 1009754 Opened 6 years ago Closed 5 years ago

crashtest 479938-1.html fails on debug OSX 10.9

Categories

(Core :: Layout: Block and Inline, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jgriffin, Assigned: gbrown)

References

Details

Attachments

(1 file)

The crashtest 479938-1.html fails consistently on OSX 10.9 debug because no asssertion is raised, and the test expects one:

REFTEST TEST-UNEXPECTED-PASS | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/generic/crashtests/479938-1.html | assertion count 0 is less than expected 1 assertions

full log: https://tbpl.mozilla.org/php/getParsedLog.php?id=39580025&tree=Cedar&full=1
The assertion that's "expected" is:

###!!! ASSERTION: math on NS_UNCONSTRAINEDSIZE: 'NS_UNCONSTRAINEDSIZE != aState.mReflowState.ComputedPhysicalBorderPadding().left && NS_UNCONSTRAINEDSIZE != aState.mReflowState.ComputedWidth()', file /builds/slave/m-cen-osx64-d-0000000000000000/build/layout/generic/nsBlockFrame.cpp, line 1667

(from https://tbpl.mozilla.org/php/getParsedLog.php?id=40337109&full=1&branch=mozilla-central)
I don't know why this "math on NS_UNCONSTRAINEDSIZE" assertion would happen on 10.8 but not 10.9.

I'm not opposed in principle to marking this test as asserts(0-1). Or nuking all the NS_UNCONSTRAINEDSIZE assertions from orbit (bug 575011 comment 10).
This still occurs: https://tbpl.mozilla.org/php/getParsedLog.php?id=46397298&tree=Cedar&full=1#error19

14:54:34     INFO -  REFTEST TEST-START | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/generic/crashtests/479938-1.html
14:54:34     INFO -  REFTEST TEST-LOAD | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/generic/crashtests/479938-1.html | 1769 / 2705 (65%)
14:54:34     INFO -  ++DOMWINDOW == 84 (0x11da4a800) [pid = 1455] [serial = 4095] [outer = 0x11b318400]
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  nsBlockReflowContext: Block(div)(0)@13e0c9a70 metrics=1073741824,1073742976!
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  nsBlockReflowContext: Block(div)(0)@13e2402c0 metrics=1073741824,1073745280!
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  nsBlockReflowContext: ColumnSet(div)(1)@13e0c9428 metrics=47040,1073745280!
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  nsBlockReflowContext: Block(body)(2)@13e0c91b8 metrics=47040,1073745280!
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  nsBlockReflowContext: ColumnSet(div)(1)@13e0c9428 metrics=47040,1073745280!
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  nsBlockReflowContext: Block(body)(2)@13e0c91b8 metrics=47040,1073745280!
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  nsBlockReflowContext: ColumnSet(div)(1)@13e0c9428 metrics=47040,1073745280!
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  nsBlockReflowContext: Block(body)(2)@13e0c91b8 metrics=47040,1073745280!
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  nsBlockReflowContext: ColumnSet(div)(1)@13e0c9428 metrics=47040,1073745280!
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  nsBlockReflowContext: Block(body)(2)@13e0c91b8 metrics=47040,1073745280!
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord width: file ../../dist/include/nsRect.h, line 82
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  [1455] WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../dist/include/nsRect.h, line 95
14:54:34     INFO -  REFTEST TEST-PASS | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/generic/crashtests/479938-1.html | (LOAD ONLY)
14:54:34     INFO -  REFTEST INFO | Loading a blank page
14:54:34     INFO -  ++DOMWINDOW == 85 (0x1102ac400) [pid = 1455] [serial = 4096] [outer = 0x11b318400]
14:54:34     INFO -  REFTEST TEST-UNEXPECTED-PASS | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/generic/crashtests/479938-1.html | assertion count 0 is less than expected 1 assertions
14:54:34     INFO -  REFTEST TEST-END | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/generic/crashtests/479938-1.html
Assignee: nobody → gbrown
(In reply to Jesse Ruderman from comment #2)
> I'm not opposed in principle to marking this test as asserts(0-1). Or nuking
> all the NS_UNCONSTRAINEDSIZE assertions from orbit (bug 575011 comment 10).

Changing the expected assertion range seems easiest...
Attachment #8477728 - Flags: review?(jruderman)
Blocks: 947089
No longer blocks: 932431
Al -- I notice Jesse hasn't had much bugzilla activity recently. Should I re-assign this (trivial!) review to someone else? (Who?)
Flags: needinfo?(abillings)
No, I'll ping Jesse.
Flags: needinfo?(abillings) → needinfo?(jruderman)
Comment on attachment 8477728 [details] [diff] [review]
change assertion range from 1 to 0-1

Review of attachment 8477728 [details] [diff] [review]:
-----------------------------------------------------------------

Fine with me, although you might want to get a review from someone qualified to review patches in the layout module.

I assume you're going to mark his bug as FIXED after checking this in, so I'd prefer if you didn't include this bug number in the patch. (I like being able to run a tool that complains if test manifest comments refer to fixed bugs, because that usually indicates a test we forgot to re-enable.)
Attachment #8477728 - Flags: review?(jruderman) → review+
Flags: needinfo?(jruderman)
Comment on attachment 8477728 [details] [diff] [review]
change assertion range from 1 to 0-1

(In reply to Jesse Ruderman from comment #7)
> Fine with me, although you might want to get a review from someone qualified
> to review patches in the layout module.

Good idea!

:roc -- Any objection to changing the expected assertion range here so that we pass on OSX 10.9?

I can leave-open if we want to follow-up or simply close it -- let me know.
Attachment #8477728 - Flags: feedback?(roc)
Please fix the assertion range. Thanks!
With bug # removed as requested in review comment:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9c32fce72d0
https://hg.mozilla.org/mozilla-central/rev/a9c32fce72d0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Attachment #8477728 - Flags: feedback?(roc)
You need to log in before you can comment on or make changes to this bug.