10098 - progess dlg crashes when trigger jars before previous one is finished

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Doug Turner (:dougt)]

Bug 5577 and 5579 have reported this problem.  Both of these test cases create
a folder, then add a bunch of files each having a append two-byte char.  (do
you remember the charset test in 4.5 - this is very similar).  When we go
across the thread boundary via proxy we crash in nsString2::Append.  Here is a
great stack trace:

Call Stack:    (Signature = MSVCRT.dll + 0xa64b (0x7800a64b) be16365b)
   MSVCRT.dll + 0xa64b (0x7800a64b)
   nsString::Assign
[d:\builds\seamonkey\mozilla\xpcom\ds\nsString2.cpp, line 877]
   nsString::nsString
[d:\builds\seamonkey\mozilla\xpcom\ds\nsString2.cpp, line 154]
   nsInstallProgressDialog::ItemScheduled
[d:\builds\seamonkey\mozilla\xpinstall\src\nsInstallProgressDialog.cpp, line
233]
   XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp,
line 135]
   EventHandler
[d:\builds\seamonkey\mozilla\xpcom\proxy\src\nsProxyEvent.cpp, line 325]
   PL_HandleEvent
[plevent.c, line 492]
   PL_ProcessPendingEvents
[plevent.c, line 453]
   _md_EventReceiverProc
[plevent.c, line 881]
   USER32.dll + 0x1250 (0x77e71250)
   nsappshell.dll + 0x17ec (0x011f17ec)
   apprunner.exe + 0x22f5 (0x004022f5)
   KERNEL32.dll + 0x1b304 (0x77f1b304)


I have not been able to reproduce this on 98.

Comment 1

[Doug Turner (:dougt)]

I can not reproduce this.  Marking as WORKS_FOR_ME.

Comment 2

[Jimmy Lee]

Reopening since 5577 and 5579 have been reopened.  This bug is similar to those.

Comment 3

[leger]

Clearing WorksForMe resolution due to reopen.

Comment 4

[Sean Su]

changing commponent to Install Wizard.

Comment 5

[Daniel Veditz [:dveditz]]

How can this be the install wizard, Sean? I'm changing it back to XPInstall

Comment 6

[Cathleen]

Jimmy commented in the meeting today, that if he click on several jars before
the previous one is finished, we will crash.

changing summary from "nsInstallProgressDialog is crashing on NT during
ItemScheduled." to "progess dlg crashes when trigger jars before previous one is
finished."

setting target milestone to M10

Comment 7

[Doug Turner (:dougt)]

I just created 100 triggered installed, and everything went fine.  Lets regress
against m9.  Marking as FIXED

Comment 8

[Jimmy Lee]

Crash with multiple files installed will be tracked in separate bug with a more
simpler test case.  Marking this bug verified.

Comment 9

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine