1009851 - [B2G][Browser][OTA][Open_C] OTA updates do not start or complete properly and can result in a bricked device.

Status: RESOLVED INVALID

(Firefox OS Graveyard :: General, defect)

Description

[Lionel Mauritson]

Attachment: recoverytest.zip

Description:
After downloading an 

Repro Steps:
1) Update a Open_C to BuildID: 20140512000204
2) Download and extract Naoki’s recoverytest.zip (Attached)
3) CD to the “bug 976450” folder within the extracted recoverytest folder. (For example: “cd home/flash/scripts/recoverytest/bug 976450”)
4) Replace the librecovery.so with the attached one.
5) Enter “./flash.sh” in the terminal. 
>>The device should restart when this process is finished.
6) Download and extract the B2G flash tools from: https://github.com/Mozilla-TWQA/B2G-flash-tool
7) CD to the folder you extracted the B2G flash tools to. (For example: “cd home/flash/scripts/B2G_Flash_Tools”)
8) Enter  “./change_ota_channel_pref.sh -d flame -v 1.4.0” in the terminal.
9) Go to Settings > Device Information and check for updates. (Wifi must be enabled)
10) When the update notification appears select it and wait for it to finish downloading.
11) When the download finishes uncompressing restart the device.

Actual:
The logcat will show the device attempting to upgrade on restart but then it gets stuck in an infinite loop with an incomplete Firefox animation looping indefinitely.

Expected:
The update can be started.
The user is informed about the progress of the update.
The device can restart with no problems and the update is successful.

1.4F Environmental Variables:
Device: Open_C 1.4F MOZ
BuildID: 20140512000204
Gaia: 17fb44880e95bc7ae363a609d811bf5a9a067b5b
Gecko: ec24f847e7c0
Version: 30.0
Firmware Version: P821A10V1.0.0B06_LOG_DL


Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/9558/
See attached: Zips and logcat

Comment 1

[Lionel Mauritson]

Attachment: librecovery.so

Comment 2

[Lionel Mauritson]

Attachment: logcat_20140513_1404_open_c_ota.txt

Comment 3

[Lionel Mauritson]

Attachment: librecovery.so

The old one was meant for the Buri. The result is the same, though.

Comment 4

[Jason Smith [:jsmith]]

Naoki - Is the problem here is the way this was tested? Or is there a different problem here?

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Talking to dhylands, I made a couple of mistakes.  
librecovery.so isn't used in OTA; only FOTA.

Also to note, he mentioned that the librecovery.so would not work if they had different values; if they had the same it might work.

Comment 6

[Dave Hylands [:dhylands]]

It looks like RECOVERY_EXTERNAL_STORAGE is compiled into librecovery.so

RECOVERY_EXTERNAL_STORAGE is set to /sdcard on the hamachi (from device/hamachi.mk)

I'm not sure what it is on the OpenC. On the Flame, its set to /storage/sdcard, so a hamachi and flame librecovery.so's are not interchangable.

Comment 7

[Jason Smith [:jsmith]]

So is this invalid then?

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I think the bug is still valid that the OTA does not work; we would need someone to look at why the device doesn't restart.  It might be a dup of bug 1009746

Comment 9

[Jason Smith [:jsmith]]

Does this reproduce if you try to test this on Flame?

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Sorry, to clarify step 11 is a a repeat of bug 1009746; the fox animation looping indefinitely is a separate issue.

Comment 11

[Lionel Mauritson]

The result on the Flame is bug 1009746

Comment 12

[Jason Smith [:jsmith]]

Note - since our reference implementation for 2.0 relies primarily on Flame, I'm going to push for bug 1009746 to block 1.4. Open C testing will be discontinued when Flame is fully ready, so we don't necessarily need to hold the release on fixing this.

Comment 13

[Jason Smith [:jsmith]]

We should retest this on a 5/22 --> 5/23 trunk build on Open C to see if we can still reproduce this.

Comment 14

[Lionel Mauritson]

Results on the 5/22 2.0.0 build: 
The device does not ask the user to install the update. 
The update can be downloaded again after appearing to have finished downloading and extracting.
The device can be restarted after which a message about the download failing appears.
The device did NOT brick after restarting.
The device was NOT updated to any new versions.
Tried with and without the recovery.so for the flame. 
The results were as noted above for 5/5 times.

Please let me know if there is any new method for setting up OTA.

Device: Open_C
BuildID: 20140522193023
Gaia: b61129780e085636d09406f2a46e922d0f8b9757
Gecko: e9b2b72f4e6c
Version: 32.0a1
Channel: change_ota_channel_pref.sh -d flame -v 2.0.0

Comment 15

[Jason Smith [:jsmith]]

Can you retest this with yesterday's build to today's build? I find it strange that the update is failing here.

Comment 16

[Joshua Mitchell (Inactive)]

Hey Jason - 

Here's an OTA bug that seems specific to Open-C. Flame repro is addressed in comment 11 and the equivalent bug is resolved-fixed.  Can we close this one as invalid?

Comment 17

[Jason Smith [:jsmith]]

Sure - we're not supporting OTA on Open C, so we can close it.