1009855 - Improve workflow for specifying custom flags to the build in marionette-js tests...

Status: RESOLVED INVALID

(Testing Graveyard :: JSMarionette, defect)

Description

[James Lal [:lightsofapollo]]

So we can test all our feature flags in the tests we need a nicer workflow maybe like this:

```js
var client = marionette.client({
  env: { MAGIC_CONFIG_FLAG: '1' }
})
```

Comment 1

[Dale Harvey (:daleharvey)]

We have tests written for the new rocketbar functionality (2.1), however this is starting to conflict with the behaviour in master, all the code is landed in master and is currently behind a HAIDA=1 build flag, the example code would be perfect

Comment 2

[Dale Harvey (:daleharvey)]

Tried looking at the flow between marionette / mozilla-profile build but having trouble understanding where / how it interacts with the rest of the gaia build system, if I could get any pointers would like to work on this, starting to block me a bit. Cheers

Comment 3

[Dale Harvey (:daleharvey)]

Hey gareth, you have any idea on this front?

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21947

Hey Dale,

I think this is what you're looking for. Try it out and let me know!

Comment 5

[Dale Harvey (:daleharvey)]

Thanks a lot Gareth, annoyed at myself for not looking deeper, I was checking the wrong repo, testing now

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: browser.patch

A brief test of this isnt working for me, with this patch when I run 

TEST_FILES=apps/system/test/marionette/rocketbar_test.js make test-integration-test

I see the browser being opened, this shouldnt happen as with HAIDA the browser activities are deleted, if I manually install HAIDA=1 make reset-gaia and enter a url, it does not open the browser app, will investigate more

Comment 7

[Dale Harvey (:daleharvey)]

Comment on attachment 8458931 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21947

Given the short time between running tests, I dont think this is doing the original proposal which is to use the flags as part of building the profile.

Kevin had other ideas which would require less infrastructure, and its looking like we need this less as the build flag is due to be removed, so I dont mind if this gets closed, either way cancelling review.

Cheers Gareth, sorry for the distraction

Comment 8

[Dale Harvey (:daleharvey)]

We no longer need this

Comment 9

[James Lal [:lightsofapollo]]

Comment on attachment 8458931 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21947

Lets keep this running fast until we make this easier and fast.

Comment 10

[Martijn Wargers (dead)]

This bug is still mentioned in http://mxr.mozilla.org/gaia/source/apps/system/test/marionette/rocketbar_test.js#43