Closed
Bug 1009858
Opened 11 years ago
Closed 11 years ago
Create keyboard accessibility tests
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access, Whiteboard: [b2ga11y p=1])
Attachments
(1 file)
Some improvements have recently landed, in bug 895443 and bug 995025. They should be in the regular test mill.
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [b2ga11y p=1]
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8422033 -
Flags: review?(zcampbell)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8422033 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19214 f+! Just a change of the new app object properties to fit the existing model and rename the test files to fit the existing style. nb I did not run the tests because they both failed on Travis. can you re-r? me after they are green and I'll run them on a device too.
Attachment #8422033 -
Flags: review?(zcampbell) → feedback+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8422033 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19214 A new patch with your feedback. The tests pass. Some e.me test failed, but I am pretty sure that is an intermittent issue since it doesn't look like that test touch the keyboard app.
Attachment #8422033 -
Flags: review?(zcampbell)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8422033 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19214 r+ , tests work well on device, too.
Attachment #8422033 -
Flags: review?(zcampbell) → review+
|
|
||
Comment 5•11 years ago
|
||
Merged: https://github.com/mozilla-b2g/gaia/commit/f9cae597d7a6e252f708fd118995e934dc49c48c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•