Closed
Bug 1009862
Opened 12 years ago
Closed 12 years ago
devicemanagerSUT's sock variable should be marked as unusable on timeout
Categories
(Testing :: Mozbase, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
|
1.00 KB,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
Noticed this when working on 1009245.
When we timeout, we raise a DMError but keep the _sock variable intact. We should set it to None so we reconnect if the user wants to retry using the same devicemanager.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8422024 -
Flags: review?(gbrown)
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Updated•12 years ago
|
Attachment #8422024 -
Flags: review?(gbrown) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Try run looks good, r+, let's get this checked in.
Keywords: checkin-needed
|
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•