Closed Bug 1009892 Opened 8 years ago Closed 8 years ago

Prepare /whatsnew to be displayed for updates from pre-29 versions

Categories

(www.mozilla.org :: General, defect)

Production
x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Habber, Assigned: agibson)

References

Details

(Whiteboard: [kb=1369716])

Attachments

(1 file)

44 bytes, text/x-github-pull-request
Details | Review
We want to show the /whatsnew tour URL to users updating from pre-29 versions of Firefox. This will impact release channel Firefox through version 31.

The URL for the upcoming Firefox 30 release will be as follows:
https://www.mozilla.org/en-US/firefox/30.0/whatsnew/?oldversion=28.0


This ensures that users who skipped the 29 launch will still see the Firefox onboarding tour. Users who did update during the 29 launch (or 29+) will not see this tour a second time. 

As a result, we can also be sure that ESR versions will also see /whatsnew upon updating.


(see bug 987480 for past implementation)
Blocks: 1009893
Currently, the Apache rules for 30+ don't show the tour page. It sounds like we want to support 30.* and 31.*.
Ok so the default behavior for /whatsnew going forward should be:

* default: no-tour (just the post tour web page)
* if ?oldversion < 29, show the tour.

This will apply to versions 29 through to 31.

Sound ok?
Whiteboard: [kb=1369716]
(In reply to Alex Gibson [:agibson] from comment #2)
> Ok so the default behavior for /whatsnew going forward should be:
> 
> * default: no-tour (just the post tour web page)
> * if ?oldversion < 29, show the tour.
> 
> This will apply to versions 29 through to 31.
> 
> Sound ok?

Jen Bertsch and I just discussed what happens for users updating from 29+. /whatsnew will be turned off until further notice for users updating from 29+ to 30-31.

Logic from Nick in bug 1009893
* Firefox 30 - show whatsnew for 28.0 and older, but not 29.0/29.0.1
* Firefox 31 - show whatsnew for 28.0 and older, but not 29.0/29.0.1/30.0/30.0.x
(In reply to Holly Habstritt Gaal [:Habber] from comment #3)
> Logic from Nick in bug 1009893
> * Firefox 30 - show whatsnew for 28.0 and older, but not 29.0/29.0.1
> * Firefox 31 - show whatsnew for 28.0 and older, but not
> 29.0/29.0.1/30.0/30.0.x

So just to clarify the logic here.

Firefox 30 and 31 will only open the /whatsnew URL for users updating from version 28.0 and older, and not for version 29 (as well as minor releases).

Therefore, all we need to do on the website side of things is make sure that the /whatsnew tour is displayed for versions 30 and 31.

Correct?
(In reply to Alex Gibson [:agibson] from comment #4)
> (In reply to Holly Habstritt Gaal [:Habber] from comment #3)
> > Logic from Nick in bug 1009893
> > * Firefox 30 - show whatsnew for 28.0 and older, but not 29.0/29.0.1
> > * Firefox 31 - show whatsnew for 28.0 and older, but not
> > 29.0/29.0.1/30.0/30.0.x
> 
> So just to clarify the logic here.
> 
> Firefox 30 and 31 will only open the /whatsnew URL for users updating from
> version 28.0 and older, and not for version 29 (as well as minor releases).
> 
> Therefore, all we need to do on the website side of things is make sure that
> the /whatsnew tour is displayed for versions 30 and 31.
> 
> Correct?

Alex - that is my understanding too.

However, not to throw a wrench into things, but what if we want to show just the post-tour landing page (like this ) to users updating from 29 to 30?  Can we do that for June 10?  Thx!
Here's the post tour landing page we'd like to show for upgrading from 29 to 30 http://cl.ly/image/3C160X21111T
Should I open a separate bug?
> However, not to throw a wrench into things, but what if we want to show just the post-tour landing page (like this ) to users updating from 29 to 30?

Yes we can do that, and no it does not require a different bug :)

However, this does imply that the logic in comment 3 is changing, right? As it stands, users updating from 29 to 30 would not see the /whatsnew page (only users updating from 28.0 or older).
(In reply to Jennifer Bertsch [:jbertsch] from comment #5)
> (In reply to Alex Gibson [:agibson] from comment #4)
> > (In reply to Holly Habstritt Gaal [:Habber] from comment #3)
> > > Logic from Nick in bug 1009893
> > > * Firefox 30 - show whatsnew for 28.0 and older, but not 29.0/29.0.1
> > > * Firefox 31 - show whatsnew for 28.0 and older, but not
> > > 29.0/29.0.1/30.0/30.0.x
> > 
> > So just to clarify the logic here.
> > 
> > Firefox 30 and 31 will only open the /whatsnew URL for users updating from
> > version 28.0 and older, and not for version 29 (as well as minor releases).
> > 
> > Therefore, all we need to do on the website side of things is make sure that
> > the /whatsnew tour is displayed for versions 30 and 31.
> > 
> > Correct?
> 
> Alex - that is my understanding too.
> 
> However, not to throw a wrench into things, but what if we want to show just
> the post-tour landing page (like this ) to users updating from 29 to 30? 
> Can we do that for June 10?  Thx!

Hi Jen, 
If the logic is changing and we want to show whatsnew for users updating from 29 and 30 as well (not just <29), I need to talk with release engineering since this updates their logic as well. Let's talk today and make sure this is final before updating the release engineering bug.
Alex, if I ask the engineering team to turn on /whatsnew for all users updating to 30 & 31, will you be able to do the following on the web side?:
- users with 28.0 and older updating to 30 & 31 will see the tour
- users with 29.0 and newer updating to 30 & 31 will NOT see the tour info panel, but will see /whatsnew post-tour page with the Sync banner http://cl.ly/image/3C160X21111T

I want to confirm that you can show conditional page content and decide to show the tour or not dependent on the users Firefox version number. Schedule a vidyo meeting for Monday if you'd like to talk this through in person.
Flags: needinfo?(agibson)
(In reply to Holly Habstritt Gaal [:Habber] from comment #10)
> Alex, if I ask the engineering team to turn on /whatsnew for all users
> updating to 30 & 31, will you be able to do the following on the web side?:
> - users with 28.0 and older updating to 30 & 31 will see the tour
> - users with 29.0 and newer updating to 30 & 31 will NOT see the tour info
> panel, but will see /whatsnew post-tour page with the Sync banner
> http://cl.ly/image/3C160X21111T
> 
> I want to confirm that you can show conditional page content and decide to
> show the tour or not dependent on the users Firefox version number. Schedule
> a vidyo meeting for Monday if you'd like to talk this through in person.

Hi Holly,

This is the same logic I describe in comment 2, right? If so, yes we should be able to do that. I may need to confirm some logic with pmac on how best to do this, but let's schedule a meeting for Monday to discuss further.
Flags: needinfo?(agibson)
(In reply to Alex Gibson [:agibson] from comment #11)
> (In reply to Holly Habstritt Gaal [:Habber] from comment #10)
> > Alex, if I ask the engineering team to turn on /whatsnew for all users
> > updating to 30 & 31, will you be able to do the following on the web side?:
> > - users with 28.0 and older updating to 30 & 31 will see the tour
> > - users with 29.0 and newer updating to 30 & 31 will NOT see the tour info
> > panel, but will see /whatsnew post-tour page with the Sync banner
> > http://cl.ly/image/3C160X21111T
> > 
> > I want to confirm that you can show conditional page content and decide to
> > show the tour or not dependent on the users Firefox version number. Schedule
> > a vidyo meeting for Monday if you'd like to talk this through in person.
> 
> Hi Holly,
> 
> This is the same logic I describe in comment 2, right? If so, yes we should
> be able to do that. I may need to confirm some logic with pmac on how best
> to do this, but let's schedule a meeting for Monday to discuss further.

Regarding comment 2, it sounds like as long as ?oldversion is passed through, we'll be fine to do what we need. I'll wait until after we meet to put details in bug 1009893.
To do this on the website side we would be totally reliant on Firefox passing through the ?oldversion parameter in the URL. It's the only way we can tell what version the user is upgrading from.
Assignee: nobody → agibson
Status: NEW → ASSIGNED
Attached file GitHub pull request
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/0ab0d91defd40157cc8e171bd71901c495a3a355
[fix bug 1009892] Prepare /whatsnew to be displayed for updates from pre-29 versions

https://github.com/mozilla/bedrock/commit/2423a6cb3f909d93701f9fda9469259841178454
Merge pull request #2029 from mozilla/bug-1009892-display-whatsnew-tour-for-pre-29-versions

[fix bug 1009892] Prepare /whatsnew to be displayed for updates from pre-29 versions
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.