Closed Bug 1010095 Opened 7 years ago Closed 7 years ago

[Build] extract |getImagePathByResolution| from webapp-zip & webapp-shared to another rule |image-resolution|

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gduan, Assigned: gduan)

References

Details

Attachments

(1 file)

Follow-up bug for bug 1002413.
We should extract isExcludedFromZip and getImagePathByResolution to another task which is executed in each app's task (bug 1008114).
Assignee: nobody → gduan
change to more explicit title, and we should also migrate |pickByResolution| in webapp-shared.js to post-process.js
Summary: [Build] webapp-zip should do zip thing only → [Build] extract |getImagePathByResolution| and |isExcludedFromZip| from webapp-zip to another rule |post-process|
Attached file PR to master
Hi Yuren,
patch is done, please kindly check, thanks!
Attachment #8436835 - Flags: review?(yurenju.mozilla)
Btw, I've already compared master and my patch with |make GAIA_DEV_PIXELS_PER_PX=1.5| and images are the same.
Hi George, I read your patch roughly but I didn't see modification of webapp-shared.js for GAIA_DEV_PIXELS_PER_PX, I suggest copying all dev-pixels files which is used in apps from shared directory and use |post-process.js| to handle all dev-pixels files.

what do you think?
Flags: needinfo?(gduan)
Yah, I forgot. Thanks for reminding.

Patch updated.
Flags: needinfo?(gduan)
George, please rebase it since bug 1021051 has been landed
Flags: needinfo?(gduan)
changing title since we only handle resolution stuff on this issue
Summary: [Build] extract |getImagePathByResolution| and |isExcludedFromZip| from webapp-zip to another rule |post-process| → [Build] extract |getImagePathByResolution| from webapp-zip & webapp-shared to another rule |image-resolution|
Comment on attachment 8436835 [details] [review]
PR to master

r=yurenju if nits are addressed and push to try for windows/mac/linux build.
Attachment #8436835 - Flags: review?(yurenju.mozilla) → review+
Flags: needinfo?(gduan)
It works fine in linux/windows/mac.

waiting for travis.
George, please keep your eye on tbpl b2g-inbound.
You need to log in before you can comment on or make changes to this bug.