1010095 - [Build] extract |getImagePathByResolution| from webapp-zip & webapp-shared to another rule |image-resolution|

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Follow-up bug for bug 1002413.
We should extract isExcludedFromZip and getImagePathByResolution to another task which is executed in each app's task (bug 1008114).

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

change to more explicit title, and we should also migrate |pickByResolution| in webapp-shared.js to post-process.js

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Yuren,
patch is done, please kindly check, thanks!

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Btw, I've already compared master and my patch with |make GAIA_DEV_PIXELS_PER_PX=1.5| and images are the same.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi George, I read your patch roughly but I didn't see modification of webapp-shared.js for GAIA_DEV_PIXELS_PER_PX, I suggest copying all dev-pixels files which is used in apps from shared directory and use |post-process.js| to handle all dev-pixels files.

what do you think?

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Yah, I forgot. Thanks for reminding.

Patch updated.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

George, please rebase it since bug 1021051 has been landed

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

changing title since we only handle resolution stuff on this issue

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8436835 [details] [review]
PR to master

r=yurenju if nits are addressed and push to try for windows/mac/linux build.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

It works fine in linux/windows/mac.

waiting for travis.

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

tbpl passed
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=0dbab82f5158

merge to master
https://github.com/mozilla-b2g/gaia/commit/444685effb612bbc6c4bcdedb78d1e04e25e218d

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

George, please keep your eye on tbpl b2g-inbound.

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

looks nice.
https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=9ec91eeb5299