1010238 - TypeError: evt is null when new window is dismissed

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Comment 1

[Dale Harvey (:daleharvey)]

We currently use https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/browser.js#L16 to open new windows via the rocketbar, when a window opened this way is dismissed we get an error at the console

E/GeckoConsole( 1807): [JavaScript Error: "TypeError: evt is null" {file: "app://system.gaiamobile.org/js/modal_dialog.js" line: 231}]

Windows opened this way have no origin, I suspect we should update places that check for origin equality and put a null check in there (apps with no origin should never be considered shared), but I am not certain.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

I just wonder why creating a appWindow will trigger modal_dialog, could you print out the call stack?

Comment 3

[Dale Harvey (:daleharvey)]

It isnt the appWindow being created thats triggering modal dialog, its the app that has been created being put in the background, thats fires an `appwillclose` event @ https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/modal_dialog.js#L107, the origin check passes with evt.detail.origin being undefined

Comment 4

[Dale Harvey (:daleharvey)]

Not currently working on this, it can only be hit on 2.1 and currently getting 2.0 bugs sorted

Noting for the future fix for this is to put a null check for the origin @ https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/modal_dialog.js#L109, I think thats the correct fix, windows the user opens do not have an origin. (giving them the search app origin, what the usual window.open behaviour would be, would mean we could only open one window)

There may be more places we need to check for null origins

Comment 5

[BMO Automation]

Firefox OS is not being worked on