1010246 - "Cell data" panel is showing in the desktopb2g FTU

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Zac C (:zac)]

When using the FTU on desktopb2g, the cell data panel is shown, even though there is possible way to enable cell data.

Gaia 2.0
Gecko 32.0a1
Build ID 20140512160204

This has regressed; previously this panel did not appear on desktopb2g.

Comment 1

[Zac C (:zac)]

FTU should detect in some way that this panel is appropriate and show/hide it.

Comment 2

[Zac C (:zac)]

Settings app has a good method of detecting the validity of the SIM and RIL; it shows/hides menu options as appropriate.

Comment 3

[Fernando Campo (:fcampo)]

AFAIK, this panel is shown for debugging needs (we needed it at some point in the past).

If getting rid of it on desktop is a must, at least I'd like to be able to show it on demand (maybe an option on the Makefile). (In reply to Zac C (:zac) from comment #0)

> This has regressed; previously this panel did not appear on desktopb2g.
Are we sure it's a regression? If it is, do we know when was it introduced?

Comment 4

[Zac C (:zac)]

I've bisected back a couple of months but only discovered that the difference is between the way the profile is built.
With releng's default profile the cell data panel is hidden.

If you make your own profile with the same flags as Travis/TBPL:
DESKTOP_SHIMS=1 make

Then you get the cell data panel.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Building with DESKTOP_SHIMS=1 should indeed making the Cell Data panel show. This is because it only shows when there is a SIM card in the 'ready' state, which the desktop shims fake for us [1]. Zac, are you saying we are seeing the Cell Data screen on b2g-desktop without the shims in travis/tbpl?


1.) https://github.com/mozilla-b2g/gaia/blob/00460b/tools/extensions/desktop-helper/content/data/lib/icc_manager.js#L10

Comment 6

[Zac C (:zac)]

No, it's only showing with the shim. I think I misunderstood this. I thought the Settings app hid these Cell data options, and it does, but it just takes a long time to initialise and then enable the menu options.

However I am not sure the SIM is ready anyway because the status bar icon is [SIM]!  and on a device that represents that the SIM is not present, not that it is ready. So how can it be in ready state but showing the icon for no SIM present? (Is this a separate bug?)

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Zac C (:zac) from comment #6)
> However I am not sure the SIM is ready anyway because the status bar icon is
> [SIM]!  and on a device that represents that the SIM is not present, not
> that it is ready. So how can it be in ready state but showing the icon for
> no SIM present? (Is this a separate bug?)

This sounds like a bug with the shims. There are multiple ways to tell if a SIM is 'ready', so it sounds like FTU and system (status bar) are examining different properties on the mozMobileConnections/mozIccInfo API's, and perhaps the shims aren't doing the right thing. Do we ever see this happening on device?

Comment 8

[Zac C (:zac)]

On a device, if you have no SIM in the device then you don't see "cell data" panel in the FTU and various panels in the Settings app are disabled. The icon in the status bar is as I described in comment #6.
There's also a SIM state where the device knows the SIM is there but the SIM isn't working (eg contract expired). I have a bad SIM but not on me right now.

Kevin, you worked on the shims a bit in the early days; is the behaviour described in comment #6 for desktopb2g as expected?

Comment 9

[Kevin Grandon :kgrandon]

We can update the shim if needed for testing, but we implemented it this way so we can test these options. (If we don't want this then we should build with DESKTOP_SHIMS=0, but I am pretty sure this will break other gaia ui tests).

The functionality of settings is that it starts up with these options disabled, and after receiving the proper events it will either enable these options or display a "No SIM card" message.

Our intent was to match desktop to a device that had a simcard when the shims are present. Let me know if there is anything you'd like to change.

Comment 10

[Zac C (:zac)]

We modified Gu to run without DESKTOP_SHIMS and this is closer to a real device now.

c#8 is probably a bug but it doesn't sound like there's any interest in resolving it.