1010322 - change toolkit/mozapps/extensions/test/browser/ tests to point at actual http servers

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: change toolkit/mozapps/extensions/test/browser/ tests to point at actual http servers

These tests reference various things at localhost:4444.  There's no web server
running at localhost:4444, so any requests ought to fail; these tests also
don't appear to require that there's actual real resources at these URLs.

But running these tests with prohibited non-local connections fails on our OS X
machines on tbpl, because "localhost" doesn't resolve properly to 127.0.0.1.  I
gather from googling this sort of thing that being unable to resolve localhost
is a common problem.

Rather than fixing it on the TBPL machines, I think it's reasonable to just
modify the tests to not point at a localhost-based server that doesn't even
exist.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8422534 [details] [diff] [review]
change toolkit/mozapps/extensions/test/browser/ tests to point at actual http servers

Review of attachment 8422534 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/test/browser/browser_bug591465.js
@@ +27,5 @@
> +                homepageURL: "http://mochi.test:8888/data/index.html",
> +                headerURL: "http://mochi.test:8888/data/header.png",
> +                footerURL: "http://mochi.test:8888/data/footer.png",
> +                previewURL: "http://mochi.test:8888/data/preview.png",
> +                iconURL: "http://mochi.test:8888/data/icon.png"

the previous port was 4444, is that needed for anything in the test?

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Joel Maher (:jmaher) from comment #2)
> the previous port was 4444, is that needed for anything in the test?

No.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/74e89d61b4bb

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3b4af0a7bee5
https://hg.mozilla.org/releases/mozilla-beta/rev/8438a548150d
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/689de95de56b
https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/2cc54c40e133
https://hg.mozilla.org/releases/mozilla-esr24/rev/b816285376ec

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/8438a548150d

Comment 7

[Ivan Tsay (:ITsay)]

Hi Ryan,

Mind if you can share why the patch was landed in all versions but only v1.4? Thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

It was a test-only change that only affects the Firefox browser test suite. This has no impact on B2G code. That said, it was merged from mozilla-beta to v1.4 in comment 6, but the status flag wasn't set.