Closed Bug 1010322 Opened 6 years ago Closed 6 years ago

change toolkit/mozapps/extensions/test/browser/ tests to point at actual http servers

Categories

(Toolkit :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32
Tracking Status
firefox30 --- fixed
firefox31 --- fixed
firefox32 --- fixed
firefox-esr24 --- fixed
b2g-v1.2 --- fixed
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

No description provided.
These tests reference various things at localhost:4444.  There's no web server
running at localhost:4444, so any requests ought to fail; these tests also
don't appear to require that there's actual real resources at these URLs.

But running these tests with prohibited non-local connections fails on our OS X
machines on tbpl, because "localhost" doesn't resolve properly to 127.0.0.1.  I
gather from googling this sort of thing that being unable to resolve localhost
is a common problem.

Rather than fixing it on the TBPL machines, I think it's reasonable to just
modify the tests to not point at a localhost-based server that doesn't even
exist.
Attachment #8422534 - Flags: review?(jmaher)
Comment on attachment 8422534 [details] [diff] [review]
change toolkit/mozapps/extensions/test/browser/ tests to point at actual http servers

Review of attachment 8422534 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/test/browser/browser_bug591465.js
@@ +27,5 @@
> +                homepageURL: "http://mochi.test:8888/data/index.html",
> +                headerURL: "http://mochi.test:8888/data/header.png",
> +                footerURL: "http://mochi.test:8888/data/footer.png",
> +                previewURL: "http://mochi.test:8888/data/preview.png",
> +                iconURL: "http://mochi.test:8888/data/icon.png"

the previous port was 4444, is that needed for anything in the test?
Attachment #8422534 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #2)
> the previous port was 4444, is that needed for anything in the test?

No.
Blocks: 995417
Assignee: nobody → nfroyd
https://hg.mozilla.org/mozilla-central/rev/74e89d61b4bb
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Hi Ryan,

Mind if you can share why the patch was landed in all versions but only v1.4? Thanks!
Flags: needinfo?(ryanvm)
Whiteboard: [approval-v1.4]
Whiteboard: [approval-v1.4] → [1.4-approval-needed]
It was a test-only change that only affects the Firefox browser test suite. This has no impact on B2G code. That said, it was merged from mozilla-beta to v1.4 in comment 6, but the status flag wasn't set.
Flags: needinfo?(ryanvm)
Whiteboard: [1.4-approval-needed]
You need to log in before you can comment on or make changes to this bug.