1010348 - "learn more" link in SiteIdentifyPopup links to desktop kb article.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chris Kitching [:ckitching]]

Here:
https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/SiteIdentityPopup.java#36

We find,

    // FIXME: Update this URL for mobile. See bug 885923.
    private static final String MIXED_CONTENT_SUPPORT_URL =
        "https://support.mozilla.org/kb/how-does-content-isnt-secure-affect-my-safety";


Bug 885923 is now fixed, and there's a shiny new article at:
https://support.mozilla.org/kb/how-does-insecure-content-affect-safety-android

Presumably the URL should be updated accordingly?

Comment 1

[Chris Kitching [:ckitching]]

Attachment: Update the link to the article produced by the other bug.

Since Margaret filed the original bug I guess you're an appropriate reviewer, although I suspect this one is going to be fairly trivial.

Comment 2

[:Margaret Leibovic]

Comment on attachment 8422547 [details] [diff] [review]
Update the link to the article produced by the other bug.

Review of attachment 8422547 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch! That must have fallen through the cracks :(

Comment 3

[Chris Kitching [:ckitching]]

https://hg.mozilla.org/integration/fx-team/rev/d1269bdb70e2

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d1269bdb70e2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

(In reply to Chris Kitching [:ckitching] from comment #3)

Please don't resolve bugs that haven't landed on m-c yet.

Comment 6

[Chris Kitching [:ckitching]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #5)
> (In reply to Chris Kitching [:ckitching] from comment #3)
> 
> Please don't resolve bugs that haven't landed on m-c yet.

Apologies. Haven't landed many of my own bugs, wasn't sure when to set the flag. Won't be repeating that error.