1010394 - Network operator setting shows the same options for both the SIMs in a DSDS scenario

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Anshul]

STR:

1. Insert a CDMA SIM in slot 1 and GSM SIM in slot 2
2. Make sure both the device is registered to network for both the SIMs
3. Go to the settings->cellular & Data -> SIM 1 ->Network operator and expect CDMA options to be displayed like Roaming Preference
4. Go to the settings->cellular & Data -> SIM 2 ->Network operator and expect GSM options to be displayed like Automatic selection.

Observed: If I choose SIM1 (CDMA) first after fresh boot then I see CDMA options for both the SIMs and I chose  SIM2 (GSM) first then I see GSM options for both the SIMs.

Comment 1

[Anshul]

Antonio, seems like the fix for bug 949741 didn't cover the DSDS scenario for data settings. Note that the voice call settings is working as expected in the same scenario as cited in this bug.

Comment 2

[Preeti Raghunath(:Preeti)]

David,

Please take a look for DSDS

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR against master

Anshul, could you test if the patch fix the problem? Thanks.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR against v1.4

Comment 5

[Anshul]

Comment on attachment 8422967 [details]
PR against master

Arthur, your patch fixed the issue. Thanks for the quick turnaround.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/829e1d6e6806509d5010faa5ba900f0cad6523f9
v1.4:   https://github.com/mozilla-b2g/gaia/commit/8eca5c19f4923432d55e676475236473252962a4

Comment 7

[Ryan VanderMeulen [:RyanVM]]

*sigh* I was asked to land these only to realize afterwards that they don't have r+ yet...

Comment 8

[Anshul]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #7)
> *sigh* I was asked to land these only to realize afterwards that they don't
> have r+ yet...
Ryan, it still doesn't. I only gave a feedback++ and not review++.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Reverted. Let's not do that again please.

Master: https://github.com/mozilla-b2g/gaia/commit/58566b525c183c549644bb92cacdf50b6998770d
v1.4:   https://github.com/mozilla-b2g/gaia/commit/32fca83da31b9a0f9a5a88f96c913a25accdc14b

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR against master

Jose, could you help review the patch? It has been tested by Anshul and worked well. Thanks.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR against v1.4

Comment 12

[Anshul]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #9)
> Reverted. Let's not do that again please.
Ryan, sorry am not sure if this comment is for me? If it is, please explain what don't you expect me to do next time.

> 
> Master:
> https://github.com/mozilla-b2g/gaia/commit/
> 58566b525c183c549644bb92cacdf50b6998770d
> v1.4:  
> https://github.com/mozilla-b2g/gaia/commit/
> 32fca83da31b9a0f9a5a88f96c913a25accdc14b

Comment 13

[Preeti Raghunath(:Preeti)]

(In reply to Anshul from comment #12)
> (In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #9)
> > Reverted. Let's not do that again please.
> Ryan, sorry am not sure if this comment is for me? If it is, please explain
> what don't you expect me to do next time.
> 
> > 
> > Master:
> > https://github.com/mozilla-b2g/gaia/commit/
> > 58566b525c183c549644bb92cacdf50b6998770d
> > v1.4:  
> > https://github.com/mozilla-b2g/gaia/commit/
> > 32fca83da31b9a0f9a5a88f96c913a25accdc14b

Anshul,

No this comment wasn't meant for you. This is for the reviewer of the patch.

Comment 14

[Preeti Raghunath(:Preeti)]

Jose

Can we please have a review on this patch?

Comment 15

[howie [:howie]]

patch done, pending review, Arthur PTO until 5/21, put ETA 5/23 for now.

Comment 16

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8423575 [details]
PR against master

LGMT, r=me

Sorry for the delay guys. Sadly I couldn't test this as I don't have a suitable device. If Anshul tested the patch I'm ok with it.

Comment 17

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8423577 [details]
PR against v1.4

LGMT master branch and v1.4 branch don't differ to much at this time, r=me

Sorry for the delay guys. Sadly I couldn't test this as I don't have a suitable device. If Anshul tested the patch I'm ok with it.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/1eb90ee7c6b74380d9414e7c95304e58136f6576
v1.4:   https://github.com/mozilla-b2g/gaia/commit/233dd43b3b976e66a619dbc1b4044ed1e3ca3e34

Comment 19

[Brogan Zumwalt [Inactive]]

New test case needs to be written to address bug.

Comment 20

[KTucker [:KTucker][Inactive 3/4/2016]]

Test case added in moztrap:

https://moztrap.mozilla.org/manage/case/14368/

Comment 21

[Cynthia Tang [:cynthiatang]]

[Environment]
Device    Flame
Gaia      e424c85eda87a40c0fa64d6a779c3fa368bf770b
Gecko     https://hg.mozilla.org/mozilla-central/rev/daa84204a11a
BuildID   20140824160205
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

[STR]
See https://moztrap.mozilla.org/manage/case/14368/ 

1. Insert an active CDMA SIM in Slot 1 and an active GSM SIM in Slot 2
2. Reset phone.
4. Navigate to Settings > Cellular & Data > SIM 1 > Network Operator
5. Navigate to Settings > Cellular & Data > SIM 2 > Network Operator
6. Reset phone.
7. Navigate to Settings > Cellular & Data > SIM 2 > Network Operator
8. Navigate to Settings > Cellular & Data > SIM 1 > Network Operator

[Actual result]
 - Step4: Network type for SIM1 (CDMA) displays "3G preferred" 
 - Setp8: Network type for SIM1 (CDMA) displays "2G only"

[Expected result]
 - Network operator options displayed like roaming preferences for CDMA. (e.g. 3G preferred)
 - User should get the same result before changing the default network type for SIM1 (CDMA)

Comment 22

[Jason Smith [:jsmith]]

Hi Cynthia,

This is an old bug that landed back in May, so what you are probably seeing is a bug specifically showing up on trunk now (potentially a regression). Could you open a separate bug for the issue you found & close this bug out, since it's already landed?

Comment 23

[Cynthia Tang [:cynthiatang]]

(In reply to Jason Smith [:jsmith] from comment #22)
> Hi Cynthia,
> 
> This is an old bug that landed back in May, so what you are probably seeing
> is a bug specifically showing up on trunk now (potentially a regression).
> Could you open a separate bug for the issue you found & close this bug out,
> since it's already landed?

Hi Jason,

Sorry, I will open a separate bug for that. Thank you.