Closed Bug 1010401 Opened 10 years ago Closed 10 years ago

Make TBPL recognize OOP b2gdesktop tests

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(1 file, 2 obsolete files)

TBPL should distinguish b2gdesktop tests run in OOP mode; currently they appear as duplicate letters on cedar (e.g., G G, one for "regular" G and the other for OOP G).

I propose to group these using "oop", so TBPL will show something like:

  M(1) R G oop(M1, R, G)

etc.
Attached patch oop.diff (obsolete) — Splinter Review
Looks ok on a local vagrant box with the tests already running on cedar.
Assignee: nobody → jgriffin
Status: NEW → ASSIGNED
Attachment #8422689 - Flags: review?(ryanvm)
Comment on attachment 8422689 [details] [diff] [review]
oop.diff

Let's do this like we're doing the desktop e10s tests (M-e10s, etc). I'm not crazy about lumping all the different test types into one grouping as it would break with all existing conventions.
Attachment #8422689 - Flags: review?(ryanvm) → review-
Attached patch Make TBPL distinguish OOP tests, (obsolete) — Splinter Review
I think this should do what you want.
Attachment #8424236 - Flags: review?(ryanvm)
Attachment #8422689 - Attachment is obsolete: true
Oops, missed a line in the previous patch.
Attachment #8424238 - Flags: review?(ryanvm)
Attachment #8424236 - Attachment is obsolete: true
Attachment #8424236 - Flags: review?(ryanvm)
Comment on attachment 8424238 [details] [diff] [review]
Make TBPL distinguish OOP tests,

Pushed with some minor tweaks:
- Adjusted for the reftest job being renamed to reftest-sanity
- Tweak the UI so that M-oop displays with just the chunk number.

https://hg.mozilla.org/webtools/tbpl/rev/718d944e6511

I want to clean some of this up, but that's fodder for another bug. I'll check tbpl-dev later tonight to make sure everything looks OK and push it to production.
Attachment #8424238 - Flags: review?(ryanvm) → review+
Depends on: 1013690
In production :)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: