Closed
Bug 1010419
Opened 10 years ago
Closed 10 years ago
Intermittent browser_wa_graph-click.js | InspectorView visible after selecting a node. | InspectorView still visible after selecting another node.
Categories
(DevTools Graveyard :: Web Audio Editor, defect)
Tracking
(firefox30 unaffected, firefox31 unaffected, firefox32 fixed, firefox-esr24 unaffected)
RESOLVED
FIXED
Firefox 32
Tracking | Status | |
---|---|---|
firefox30 | --- | unaffected |
firefox31 | --- | unaffected |
firefox32 | --- | fixed |
firefox-esr24 | --- | unaffected |
People
(Reporter: RyanVM, Assigned: jsantell)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
8.39 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=39663456&tree=Mozilla-Inbound WINNT 6.2 mozilla-inbound opt test mochitest-devtools-chrome on 2014-05-14 09:30:10 PDT for push 269ba1d7f4df slave: t-w864-ix-056 09:46:43 INFO - TEST-START | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js 09:46:43 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Initializing a web audio editor pane. 09:46:43 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Adding tab: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_complex-context.html 09:46:43 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Unexpected value strokewidth parsing markerUnits attribute." {file: "chrome://browser/content/devtools/d3.js" line: 589}] 09:46:43 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Tab added and finished loading: http://example.com/browser/browser/devtools/webaudioeditor/test/doc_complex-context.html 09:46:44 INFO - JavaScript warning: chrome://browser/content/devtools/d3.js, line 479: mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "TypeError: mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create" {file: "chrome://browser/content/devtools/d3.js" line: 479}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Waiting for event: 'start-context' on [Front for webaudio/conn322.webaudio34]. 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Waiting for event: 'navigate' on TabTarget:[object XULElement]. 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Error in parsing value for 'text-anchor'. Declaration dropped." {file: "chrome://browser/content/devtools/webaudioeditor.xul" line: 0 column: 0 source: "left"}] 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Console message: [JavaScript Warning: "Unexpected value strokewidth parsing markerUnits attribute." {file: "chrome://browser/content/devtools/d3.js" line: 589}] 09:46:44 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | InspectorView hidden on start. 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Waiting for event: 'WebAudioEditor:UIInspectorToggled' on [object ChromeWindow]. 09:46:44 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | InspectorView visible after selecting a node. 09:46:44 INFO - Stack trace: 09:46:44 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js :: spawnTest :: line 30 09:46:44 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 298 09:46:44 INFO - JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Handler.prototype.process :: line 863 09:46:44 INFO - JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.walkerLoop :: line 742 09:46:44 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 09:46:44 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | InspectorView has correct node set. 09:46:44 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | InspectorView still visible after selecting another node. 09:46:44 INFO - Stack trace: 09:46:44 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js :: spawnTest :: line 34 09:46:44 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 298 09:46:44 INFO - JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Handler.prototype.process :: line 863 09:46:44 INFO - JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.walkerLoop :: line 742 09:46:44 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 09:46:44 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | InspectorView has correct node set on second node. 09:46:44 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Clicking the same node again works (idempotent). 09:46:44 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Clicking on a <rect> works as expected. 09:46:44 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Clicking on a <tspan> works as expected. 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Destroying the web audio editor. 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Waiting for event: 'destroyed' on [object Object]. 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Removing tab. 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | Tab removed and finished closing. 09:46:44 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | finish() was called, cleaning up... 09:46:44 INFO - TEST-INFO | MEMORY STAT vsize after test: 1081851904 09:46:44 INFO - TEST-INFO | MEMORY STAT vsizeMaxContiguous after test: 1893662720 09:46:44 INFO - TEST-INFO | MEMORY STAT residentFast after test: 476819456 09:46:44 INFO - TEST-INFO | MEMORY STAT heapAllocated after test: 168099790 09:46:44 INFO - INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/webaudioeditor/test/browser_wa_graph-click.js | finished in 1233ms
Assignee | ||
Comment 1•10 years ago
|
||
Hopefully this fixes. During initialization/reset, there were some race conditions in opening/closing, and having them not be animated or waiting to delay a few cycles should fix this.
Attachment #8423310 -
Flags: review?(vporof)
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=c509aa330d0c
Comment 3•10 years ago
|
||
Comment on attachment 8423310 [details] [diff] [review] 1010419-intermittent-audionodeinspector-fail.patch Review of attachment 8423310 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/webaudioeditor/test/browser_wa_graph-click.js @@ +67,5 @@ > + // assume it's an ID and find the related graph node > + let element = el.tagName ? el : findGraphNode(panelWin, el); > + click(panelWin, element); > + > + return Promise.all(promises); Gratuitous Promise.all ?
Attachment #8423310 -
Flags: review?(vporof) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/d1a122c1cbfe
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d1a122c1cbfe
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Reporter | ||
Updated•10 years ago
|
status-firefox30:
--- → unaffected
status-firefox31:
--- → unaffected
status-firefox32:
--- → fixed
status-firefox-esr24:
--- → unaffected
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•