1010442 - Allow users to browse past events

Status: RESOLVED FIXED

(Webmaker Graveyard :: Events, defect)

Description

[Brett Gaylor [:brett]]

As we build in storytelling options such as photos and makes, it will become useful for other users to see what happens at events.  Add a simple list view method to view past events.

Comment 1

[Matt Thompson (@OpenMatt :OpenMatt)]

* Marking this for [July25] release, as its not critical for Maker Party start

Comment 2

[Gavin Suntop [:gvn]]

Attachment: https://github.com/mozilla/webmaker-events-2/pull/138

Comment 3

[Brett Gaylor [:brett]]

Just verifying that this allows users to *browse* past events - the original comment is descriptive, not so much the bug title :)

Comment 4

[Matt Thompson (@OpenMatt :OpenMatt)]

* who's taking this one for [july25]? Gavin or Kate?

Comment 5

[inactivate account for kate]

Looks like gavin has a patch

Comment 6

[Gavin Suntop [:gvn]]

I made a checkbox next to the search field to search past events too. Just browsing a huge list of past events doesn't seem that useful to me, but maybe I'm missing something? There are a HUGE number of past events, so just presenting a list view seems overwhelming.

Brett, is this checkbox approach ok?

Comment 7

[Brett Gaylor [:brett]]

Its discovery.  People want to a) know what events are like and b) have events that they made discoverable.  

So yes we need a large list of past events, but sortable in descending order (most recent first) - something like "recent events on homescreen"
https://www.evernote.com/shard/s230/sh/a64b8bf8-d8b3-4cb6-b0d4-18a92169d805/53ef3d0de81a6ed6fbfad4fb2c74bd63

And when a user browses "see all events", a method to filter between upcoming (as is currently displayed) and recent (full paginated list of past events in descending order)

Comment 8

[Gavin Suntop [:gvn]]

Just spoke w. Brett on IRC. We'll go ahead and land my patch once it's R+'d and then see how we want to augment further...

Comment 9

[Ali Al Dallal [:alicoding]]

Brett, can you file a bug for that one you spoke to me on IRC? I just want to make sure is file and I know what exactly I have to do again before I forget.

Comment 10

[Brett Gaylor [:brett]]

Ali essentially what we need is a tab for "past events" on this page, 
https://events.webmaker.org/#!/events

That would show a paginated list, starting with most recent, of past events.

which would also require a tab for "upcoming events", which would be the current view.

Comment 11

[Ali Al Dallal [:alicoding]]

Assigning this to myself so I can work on past events tab.

Comment 12

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/webmaker-events-service/pull/84

Comment 13

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/webmaker-events-2/pull/158

Comment 14

[Jon Buckley [:jbuck]]

Comment on attachment 8460945 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/84

Travis CI is failing, and this will mess up pagination order. To fix this, take a look at that sequelize issue. You need to wrap your ordering in double brackets, like so: [['beginDate', 'DESC']].

I almost wonder if we should take out the API ordering of events, since that will never function correctly with pagination. Maybe in another ticket!

Comment 15

[Jon Buckley [:jbuck]]

Comment on attachment 8460945 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/84

One more thing to do in this PR is to remove the [] around the sequelize query... if this is confusing, just ping me on IRC!

Comment 16

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-events-2

https://github.com/mozilla/webmaker-events-2/commit/81d23f3e6fd47fc13ccc2c2c0ce15447ce63b7ca
Bug 1010442 - Allow users to browse past events

Comment 17

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-events-service

https://github.com/mozilla/webmaker-events-service/commit/5790866f0cabc6d5863a1d4f11dd98216801c63c
bug1010442 - Implement before query API for past events