1010490 - [Camera][Flame] Zoom bar overlaps recording timer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: Screencap_Camera.png

Steps to reproduce:

1. Open camera
2. Rotate camera to landscape (clockwise/counter clockwise)
3. Record a video and zoom in/out
4. The position of the zoom bar is off while in landscape mode.

The aspect ratio of the Flame device is the same as Madai so this should scale accurately.

I've attached screens shots and the original Madai spec for zoom bar placement. Thanks!

Comment 1

[Amy Lee [:amylee] UX]

Attachment: CSS_Pixels_Dual_Shutter_Orientation.png

Comment 2

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 3

[Amy Lee [:amylee] UX]

Comment on attachment 8423093 [details] [review]
pull-request (master)

Hi Wilson, 

The positioning looks good! Thanks.

Comment 4

[Amy Lee [:amylee] UX]

I noticed that the zoom bar moves the opposite direction when you rotate the camera 90 degrees clockwise in landscape mode. I've filed a bug for it (Bug 1011126).

Comment 5

[Justin D'Arcangelo [:justindarc]]

Amy: The bug you filed (Bug 1011126) is describing a behavior that only happens when using this patch which has not landed yet. The issue is caused by this patch (doesn't happen on master). I'm going to R- this so that Wilson can address it. Could you please confirm that Bug 1011126 does not happen on master and close it? Thanks.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8423093 [details] [review]
pull-request (master)

R-

This patch messes with the CSS transform origin and ends up having an inverted Zoom Bar in landscape orientation.

Comment 7

[Amy Lee [:amylee] UX]

Attachment: zoom_bar_screen.png

When the camera is rotated 90 degrees clockwise, the zoom bar max zoom out button position is wrong. When the camera is zoomed out, the button should be on the bottom of the bar and not at the top (see screenshot). Thanks.

Comment 8

[Justin D'Arcangelo [:justindarc]]

(In reply to Amy Lee [:amylee] from comment #7)
> Created attachment 8425473 [details]
> zoom_bar_screen.png
> 
> When the camera is rotated 90 degrees clockwise, the zoom bar max zoom out
> button position is wrong. When the camera is zoomed out, the button should
> be on the bottom of the bar and not at the top (see screenshot). Thanks.

Amy: This was certainly the case with Wilson's first patch, however it seems to be fixed in the updated version. Please make sure you test with the latest version of his patch:

`git fetch wilsonpage`
`git checkout wilsonpage/1010490`
`make install-gaia APP=camera`

Comment 9

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8423093 [details] [review]
pull-request (master)

This revised patch seems to work as it should now. Looks good. A couple of nits in the CSS, but nothing to block this from landing.

Comment 10

[Wilson Page [:wilsonpage]]

Landed on 'master' https://github.com/mozilla-b2g/gaia/commit/84d12a6ed7d6171967455ba3f418d853b534a31b

Comment 11

[Amy Lee [:amylee] UX]

(In reply to Justin D'Arcangelo [:justindarc] from comment #8)
> (In reply to Amy Lee [:amylee] from comment #7)
> > Created attachment 8425473 [details]
> > zoom_bar_screen.png
> > 
> > When the camera is rotated 90 degrees clockwise, the zoom bar max zoom out
> > button position is wrong. When the camera is zoomed out, the button should
> > be on the bottom of the bar and not at the top (see screenshot). Thanks.
> 
> Amy: This was certainly the case with Wilson's first patch, however it seems
> to be fixed in the updated version. Please make sure you test with the
> latest version of his patch:
> 
> `git fetch wilsonpage`
> `git checkout wilsonpage/1010490`
> `make install-gaia APP=camera`

Hi Justin, 

I had tested it on the latest patch at the time I left my comment. Wilson had just fixed it after my comment and IRC'd me to check it again :-) 

There is a lag issue with the zoom bar and the circle button when you are zooming in and out quickly in different orientations other than the default. I have filed a separate bug for this (Bug 013331).

Comment 12

[Amy Lee [:amylee] UX]

I meant this bug 1013331