Closed Bug 1010523 Opened 10 years ago Closed 7 years ago

Send profiler data across RDP as a string/bulk data transport

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: fitzgen, Unassigned)

References

Details

There used to be bug 795910 for this, but then we assumed bug 797639 would change the profiler as well, which didn't happen...
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
SPS Profiler right now accumulates data and converts it into a string -- from there, we get the data as an object (nsIProfiler.getProfileData) in the profiler actor server, and send it up over RDP (which it then gets cast to a string, and then reparsed on the client). This adds a few redundant steps and adds time when the buffer is large (pretty easy).

If we continue not acting on the parsed data in the profiler server (could this change? Could source maps be handled on the client lazily maybe?), then we should just send back the stringed data to the client where it's then parsed, saving a full cycle of stringifying/parsing.

Maybe a separate bug depending on complexity, but we can also use RDP's bulk data option to stream the strings over the wire, and has had huge improvements for FxOS packages in WebIDE[0].

[0] https://bugzilla.mozilla.org/show_bug.cgi?id=924574#c13
Summary: Use the bulk data transport to send profiler data across the RDP → Send profiler data across RDP as a string/bulk data transport
The RDP is currently planned to be re-architected. We will be investigating the proper way to do this efficiently. This bug doesn't appear to be specifically actionable, so I'm going to close it.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.