Closed Bug 1010528 Opened 10 years ago Closed 10 years ago

Replace map graphic with a more vivid SVG

Categories

(Webmaker Graveyard :: webmaker.org, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: akirose, Assigned: akirose)

References

Details

(Whiteboard: [resources][2014Q2][June13])

Attachments

(1 file)

I noticed after the fact that the map graphic on webmaker.org/explore that I saved for web from illustrator with a transparent background isn't as saturated as the version it replaced. This is definitely a two birds with one stone ticket. Replace the responsive PNGs with an SVG that's more saturated.

Actually three birds because after I re-exported the graphic, 
https://github.com/mozilla/webmaker.org/blob/master/public_angular/views/main.html#L19
height on image is wrong
Whiteboard: [textbook][soft-launch] → [resources][2014Q2][May30]
Whiteboard: [resources][2014Q2][May30] → [resources][2014Q2][June13]
* Who should we assign this to? Aki?
Flags: needinfo?(aki)
Yup I got it
Flags: needinfo?(aki)
QA Contact: aki
Status: NEW → ASSIGNED
Assignee: nobody → aki
QA Contact: aki
Comment on attachment 8432805 [details] [review]
https://github.com/mozilla/webmaker.org/pull/765

Almost good just a few minor things + travis seems to be mad?
Attachment #8432805 - Flags: review?(kate) → review-
Attachment #8432805 - Flags: review- → review?(kate)
Comment on attachment 8432805 [details] [review]
https://github.com/mozilla/webmaker.org/pull/765

Just make sure you take a look at lint
Attachment #8432805 - Flags: review?(kate) → review+
Yeah it looks like there was a merge from last week that made the linter mad. (This got merged in while the build was already broken, so it was accidentally looked over)

Anyway I fixed it in this commit.
Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/760b61532c3f238b9200a42da0bc25ad3b74888c
Fixes bug 1010528 - Replace map graphic with a more vivid SVG

https://github.com/mozilla/webmaker.org/commit/b454d125f750d16f2980cc894ab66fe53dbedd09
Merge pull request #765 from gesa/1010528/img-to-svg

Fixes bug 1010528 - Replace map graphic with a more vivid SVG
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: