1010553 - Create a gaia-switch web component

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

A gaia switch web component would be useful to have. I would like to take this and start experimenting with web components.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Mostly WIP - but please feel free to add any comments if you have them.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8422736 [details] [review]
Github pull request

Hey Guys!

Thought I'd give a component a shot here. Please take a look and let me know what you think. I copied most of the comment blocks from the gaia-header component as we are waiting on the same platform issues for most of these.

Comment 3

[Yan Or]

Kevin, nice one!  I made some comments on the PR.

Comment 4

[Wilson Page [:wilsonpage]]

kgrandon: Love it! Couple of nits, most importantly making sure web-component styling is standalone/decoupled from old building block.

Comment 5

[Wilson Page [:wilsonpage]]

Comment on attachment 8422736 [details] [review]
Github pull request

Nice that we have broken free from BB :)

Looks to me like the PNGs could be ditched at some point. No reason why those can't be done with pure CSS removing all the @2x crap, plus would make them 'themeable' :)

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8422736 [details] [review]
Github pull request

+1 to getting rid of PNGs, let's definitely try to do that in the future :)

Thanks for the review. I'd like to move fast on this stuff, so going to land. If you guys have any other feedback we can address it.

Comment 7

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/6c7c58de03ccc0060a16ff36a649175098dc0139

Comment 8

[Kevin Grandon :kgrandon]

Landed a follow-up to move tests to mirror elements folder as we will be landing several of these:

https://github.com/mozilla-b2g/gaia/commit/2a7ee1d0777ddafd2df31b7779be578d3f0dcbae

Comment 9

[Kevin Grandon :kgrandon]

I landed a small commit as a follow-up to rename the gaia-switch file paths to be gaia_switch.

https://github.com/mozilla-b2g/gaia/commit/b53f4a8c02722423ef17aacf9c6cce5c2276a23a